1734698 - The highlight border of the default button is not displayed even if with Default(system) theme. And also no mouse hover feedback

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Alice0775 White]

Attachment: image.png

Stes To Reproduce:

1. Start firefox.exe -p
   --- observe
2. Open Dialog (not tab modal dialog)
   such as Password Required import From Another Browser
   --- observe

Actual results:
No highlight border for default button

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=3864fbda86cb6cdfed2353be3e39edca79735221&tochange=cc9028cb90d72d12c13e2af25a996abfcd68ecba

Comment 1

[Alice0775 White]

And also no mouse hover feedback.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Hmm, that's not right, we shouldn't use the non-native theme there if the system is light.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1734698 - Override nsNativeThemeWin::CreateWebRenderCommands. r=mstange

Oversight from the regressing bug, without this we always draw supported widgets
with the non-native theme, even when the native theme also supports it.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c1acf3eec350
Override nsNativeThemeWin::CreateWebRenderCommands. r=mstange

Comment 5

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/c1acf3eec350

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Beta is not affected afaict.

Comment 8

[Anca Soncutean, Desktop QA]

Reproduced with Fx 95.0a1 (2021-10-07) on Windows 10.
Verified fixed with Fx 96.0a1 (2021-11-02) and Fx 95.0b2 on Windows 10.