1734690 - The highlight border of the default button is not displayed with Dark Theme

Status: NEW

(Toolkit :: Themes, defect, P2)

Description

[Alice0775 White]

Attachment: image.png

Steps To reproduce:

1. Enable Dark Theme
2. Open Dialog (not tab modal dialog)
   such as Password Required import From Another Browser

Actual Results:
The highlight border of the default button is not displayed

Regression Window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ef7b596bb385f46280eb1492009bf8fb541e17db&tochange=b94153cca1f7d677fbbcc1a0d4923d81ddec8958

Comment 1

[Emilio Cobos Álvarez (:emilio)]

This is somewhat expected because the native theme doesn't do anything special about default buttons... I guess the native theme does this, which is just drawing them as focused.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1734359

Comment 3

[Mathew Hodson]

I think bug 1734297 was the regressing bug from that push log.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:dao, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:jimm, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 6

[Alice0775 White]

Windows10 OS Light-mode + Firefox dark mode theme
Regressed by: Bug 1734297

Windows10 OS dark-mode + Firefox system default theme
Regressed by: Bug 1733569

Comment 7

[Shane Hughes [:aminomancer]]

Attachment: The results of loading common.css (with some minor modifications) in the new dark mode responsive dialogs. For example, unknownContentType.xhtml

Maybe this is another reason why common.css should be loaded in dialogs. I did basically that in my custom theme and it looks better imo