1734767 - Light themes - Improve visibility for key icon in saved logins dropdown

Status: VERIFIED FIXED

(Firefox :: about:logins, defect)

Description

[Cristian Fogel [:cfogel]]

Attachment: fb.png

Affected versions

• 95.0a1(20211007091917), 94.0b3

Affected platforms

• Win10;
• will check other OSs when time permits it;

Steps to reproduce

1. Launch Firefox and save a few logins on https://www.facebook.com/
2. Access https://www.facebook.com/
3. Click inside the user/pass fields and hover over the available logins/passwords;

Expected result

• key icon is visible;

Actual result

• colors are to close one to another

Regression range

• will check when time permits it;

Additional notes

• on dark theme it's a bit more visible;
• attached screenshot with the issue.

Comment 1

[Cristian Fogel [:cfogel]]

Not a regression.
Visible with addition of Monochromatic themes: such as Graffiti balanced, Cheers soft, Abstract Bold, Foto Balanced.

Comment 2

[Cristian Fogel [:cfogel]]

set theme on Light.
Got the range:
good: 2021-10-01
bad: 2021-10-02
pushlog: URL
mozregression pointed towards bug 1733354 as being at fault.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug is a defect, but please change it back in case of error.

Comment 4

[Mathew Hodson]

I used mozregression --find-fix and this issue was fixed by bug 1734297.

First good revision: b94153cca1f7d677fbbcc1a0d4923d81ddec8958
Last bad revision: ef7b596bb385f46280eb1492009bf8fb541e17db
Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ef7b596bb385f46280eb1492009bf8fb541e17db&tochange=b94153cca1f7d677fbbcc1a0d4923d81ddec8958

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1733354

Comment 6

[Mathew Hodson]

This is a visual regression in the default light theme.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Hmm, if this is an issue in 94 we should probably fix it.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Let's un-dupe this then and call it fixed on 95 by bug 1734297. I'm not sure we want to try backporting that bug to Beta, though, so agreed with trying to find a more scoped fix here instead.

Comment 10

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1734767 - [beta] Don't override Graytext on windows dark mode. r=dholbert

Comment 11

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9245676 [details]
Bug 1734767 - [beta] Don't override Graytext on windows dark mode. r=dholbert

Beta/Release Uplift Approval Request

• User impact if declined: Comment 0
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Make graytext return light colors like most other system colors on beta.
• String changes made/needed: none

Comment 12

[Giorgia Nichita, Release Desktop QA]

I was not able to reproduce this on an affected Nightly build, neither using dark or light theme. I see no difference between the Nightly from 2021-10-07 and the one from 2021-10-14.
The only way I can reproduce this issue is on a 94 Beta build, with Dark theme enabled at OS level.
Tested on: Windows 10x64.

Emilio, any thoughts about this?

Comment 13

[Emilio Cobos Álvarez (:emilio)]

The range of affected nightlies is pretty small, so not super-surprising. I could probably find one that repros but it's not a big deal IMO. We should just fix the bug in beta by uplifting comment 11.

Comment 14

[Dianna Smith [:diannaS]]

Comment on attachment 9245676 [details]
Bug 1734767 - [beta] Don't override Graytext on windows dark mode. r=dholbert

Approved for 94.0b6

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/7692ec3287f9

Comment 16

[Ryan VanderMeulen [:RyanVM]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #15)

https://hg.mozilla.org/releases/mozilla-beta/rev/7692ec3287f9

This specific commit was backed out as part of the rebasing effort for bug 1734115. The end result of the fix is still in place, however.
https://hg.mozilla.org/releases/mozilla-beta/rev/59b63f067f11

Comment 17

[Giorgia Nichita, Release Desktop QA]

The issue is verified as fixed on latest Beta 94.0b6, Win 10x64. I also verified that the fix didn't affect the behavior on Nightly.

I have noticed that on macOS and Linux with Dark mode enabled at OS level, using the System theme, the panel has a dark background, but on Windows has a white background. Is this intended or should I log a new issue for this?

Comment 18

[Emilio Cobos Álvarez (:emilio)]

Yeah, that's expected on Windows because we don't have dark mode support in beta.