1734933 - type-column-label is missing from zh-CN language pack

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Rachel Martin]

TB 92.1.0 was built with zh-CN pinned to:
1123d13bbf75fcfa5111c1207c955e3ec447e54e

https://hg.mozilla.org/releases/comm-esr91/rev/092ce734a8fcc2da3837c332bd30ea89baeeeccd#l1.754

The relevant file at that ref has:
https://hg.mozilla.org/l10n-central/zh-CN/file/1123d13bbf75fcfa5111c1207c955e3ec447e54e/mail/messenger/preferences/preferences.ftl#l414

type-column-label =
    .label = 内容类型
    .accesskey = T

However, the language pack produced from the file
http://ftp.mozilla.org/pub/thunderbird/releases/91.2.0/linux-x86_64/xpi/zh-CN.xpi
has a hole where those strings should be:

search-handler-table =
    .placeholder = 过滤内容类型和操作

[this is line 414 and it's empty]

action-column-label = 操作

Something has gone wrong producing the language pack and most likely the localised version.

Comment 1

[Francesco Lodolo [:flod]]

Because the string has a different structure in English, so the translation is discarded
https://searchfox.org/comm-central/source/mail/locales/en-US/messenger/preferences/preferences.ftl#408

type-column-label = Content Type

That's once again caused by developers changing strings after landing without new IDs.
https://mozilla-l10n.github.io/documentation/localization/making_string_changes.html

I pointed out a few in another bug, but my comment was ignored.

Comment 2

[Francesco Lodolo [:flod]]

For the future, please don't CC me to Thunderbird bugs.

I'm happy to help out if the relevant folks can't figure out things, but that's what NI is for.
https://bugzilla.mozilla.org/show_bug.cgi?id=1728893#c10

Comment 3

[Rachel Martin]

Sorry for the CC, Francesco, that happened by cloning the bug you mentioned. Thanks a lot for your input. Indeed, string changes were made here
https://hg.mozilla.org/comm-central/rev/a0b86bbaaa09#l3.1
without creating new string IDs. Many locales haven't followed that change:
https://searchfox.org/l10n/search?q=type-column-label&path=&case=false&regexp=false

Comment 4

[Henry Wilkes (they/them) [:henry-x]]

Yup, that's my bad. This patch is from before I knew about the need to change fluent ids when adding or removing attributes.

I'll put in a patch to change the ids now. But since this is a string change, I'm not sure if it can be fixed for 91.

Comment 5

[Rachel Martin]

(In reply to Henry Wilkes [:henry] from comment #4)

I'll put in a patch to change the ids now. But since this is a string change, I'm not sure if it can be fixed for 91.

See discussion in bug 1728893 comment #13 and https://hg.mozilla.org/releases/comm-esr91/rev/79de824011b8.

Comment 6

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1734933 - Rename ids for fluent changes in rev a0b86bbaaa09. r=aleca

Also use a span instead of a div for better semantics within a button.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a89c4d01471d
Rename ids for fluent changes in rev a0b86bbaaa09. r=aleca

Comment 8

[Henry Wilkes (they/them) [:henry-x]]

(In reply to Rachel Martin from comment #0)

has a hole where those strings should be:

search-handler-table =
    .placeholder = 过滤内容类型和操作

[this is line 414 and it's empty]

action-column-label = 操作

It is weird that action-column-label was changed in the translation, whilst type-column-label wasn't. I made the same mistake with both fluent entries. Maybe someone manually spotted the change for one but not the other.

Comment 9

[Henry Wilkes (they/them) [:henry-x]]

Comment on attachment 9245215 [details]
Bug 1734933 - Rename ids for fluent changes in rev a0b86bbaaa09. r=aleca

[Approval Request Comment]
Regression caused by (bug #): 1683303
User impact if declined: Translations missing headers for the File & Attachments Actions table in preferences
Testing completed (on c-c, etc.): No
Risk to taking this patch (and alternatives if risky): The patch is small, but it does introduce a new string, so I think it may require some extra steps. Currently, 24 languages already have translations for the new strings https://searchfox.org/l10n/search?q=type-column-header&path=&case=false&regexp=false . For other languages, most will simply continue to have missing translations, but some that already compensated for the change in bug 1683303 will loose translations: basically any language in this list https://searchfox.org/l10n/search?q=type-column-label&path= and not in the other list, that is of the form type-column-label = abcde rather than type-column-label =\n .label = abcde, e.g. the german translation.

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9245215 [details]
Bug 1734933 - Rename ids for fluent changes in rev a0b86bbaaa09. r=aleca

[Triage Comment]
Approved for esr91

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 91.3.1:
https://hg.mozilla.org/releases/comm-esr91/rev/60023029af68