1734997 - Prototype Prioritized Task Scheduling API

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P3)

Description

[Sean Feng [:sefeng]]

https://wicg.github.io/scheduling-apis/

Comment 1

[Sean Feng [:sefeng]]

Attachment: Bug 1734997 - Prototype the Prioritized Task Scheduling API r=smaug

Spec: https://wicg.github.io/scheduling-apis/

Comment 2

[Sean Feng [:sefeng]]

Attachment: Bug 1734997 - Fix some failures related to the new interfaces that are introduced by the Scheduling API r=smaug

Depends on D133494

Comment 3

[Sean Feng [:sefeng]]

Attachment: Bug 1734997 - Fix the setPriority-delayed-task test in Firefox r=smaug

Depends on D133495

Comment 4

[Sean Feng [:sefeng]]

Attachment: Bug 1734997 - Enable WPT for the Prioritized Task Scheduling API r=smaug

Depends on D133497

Comment 5

[Sean Feng [:sefeng]]

Attachment: Bug 1734997 - Don't reduce timer precision for post-task-delay.any.js r=smaug

If the timer preceision is reduced, the elapsed time between to
timers maybe shorter than the acutal result. And this fact
made this test to fail, so here we disable this feature for this
test.

Comment 6

[Sean Feng [:sefeng]]

Attachment: Bug 1734997 - Don't clamp the timeout for the ones that are posted by WebTaskScheduler r=smaug

This is the expected behavior according to the spec.

Comment 7

[Sean Feng [:sefeng]]

Attachment: Bug 1734997 - Add a test to test aborting the signal in postTask's callback r=smaug

Comment 8

[Sean Feng [:sefeng]]

Attachment: Bug 1734997 - Allow some timeouts not to clamp in workers r=smaug

Depends on D133494

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09469f7dd10e
Prototype the Prioritized Task Scheduling API r=smaug
https://hg.mozilla.org/integration/autoland/rev/5e624d630397
Allow some timeouts not to clamp in workers r=smaug
https://hg.mozilla.org/integration/autoland/rev/724cccd1d595
Fix some failures related to the new interfaces that are introduced by the Scheduling API r=smaug
https://hg.mozilla.org/integration/autoland/rev/55c6e7862298
Fix the setPriority-delayed-task test in Firefox r=smaug
https://hg.mozilla.org/integration/autoland/rev/3a138b8501ec
Enable WPT for the Prioritized Task Scheduling API r=smaug
https://hg.mozilla.org/integration/autoland/rev/0846da0f5ab1
Don't reduce timer precision for post-task-delay.any.js r=smaug
https://hg.mozilla.org/integration/autoland/rev/7ab1e7cc8f6a
Add a test to test aborting the signal in postTask's callback r=smaug

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/33699 for changes under testing/web-platform/tests

Comment 11

[Marian-Vasile Laza]

Backed out 7 changesets (Bug 1734997) for causing bustages on WebTaskSchedulerMainThread.cpp.
Backout link
Push with failures - Bp-hybrid
Failure Log

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 13

[Sean Feng [:sefeng]]

backed out due to build failures on Bp-hybird. Confirmed it's fixed with the updated patch. https://treeherder.mozilla.org/jobs?repo=try&revision=d18031d4316f4fdf60af2eac93d7369de6267476

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ab87d3254a13
Prototype the Prioritized Task Scheduling API r=smaug
https://hg.mozilla.org/integration/autoland/rev/e5a0ef58ae70
Allow some timeouts not to clamp in workers r=smaug
https://hg.mozilla.org/integration/autoland/rev/0713b093b0a6
Fix some failures related to the new interfaces that are introduced by the Scheduling API r=smaug
https://hg.mozilla.org/integration/autoland/rev/60c9527ee051
Fix the setPriority-delayed-task test in Firefox r=smaug
https://hg.mozilla.org/integration/autoland/rev/f1b93e2426fe
Enable WPT for the Prioritized Task Scheduling API r=smaug
https://hg.mozilla.org/integration/autoland/rev/64d6672ab0f5
Don't reduce timer precision for post-task-delay.any.js r=smaug
https://hg.mozilla.org/integration/autoland/rev/a440fb0e93f1
Add a test to test aborting the signal in postTask's callback r=smaug

Comment 15

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/ab87d3254a13
https://hg.mozilla.org/mozilla-central/rev/e5a0ef58ae70
https://hg.mozilla.org/mozilla-central/rev/0713b093b0a6
https://hg.mozilla.org/mozilla-central/rev/60c9527ee051
https://hg.mozilla.org/mozilla-central/rev/f1b93e2426fe
https://hg.mozilla.org/mozilla-central/rev/64d6672ab0f5
https://hg.mozilla.org/mozilla-central/rev/a440fb0e93f1

Comment 16

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 17

[Alexandru Ionescu (needinfo me) [:alexandrui]]

(In reply to Pulsebot from comment #9)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09469f7dd10e
Prototype the Prioritized Task Scheduling API r=smaug
https://hg.mozilla.org/integration/autoland/rev/5e624d630397
Allow some timeouts not to clamp in workers r=smaug
https://hg.mozilla.org/integration/autoland/rev/724cccd1d595
Fix some failures related to the new interfaces that are introduced by the
Scheduling API r=smaug
https://hg.mozilla.org/integration/autoland/rev/55c6e7862298
Fix the setPriority-delayed-task test in Firefox r=smaug
https://hg.mozilla.org/integration/autoland/rev/3a138b8501ec
Enable WPT for the Prioritized Task Scheduling API r=smaug
https://hg.mozilla.org/integration/autoland/rev/0846da0f5ab1
Don't reduce timer precision for post-task-delay.any.js r=smaug
https://hg.mozilla.org/integration/autoland/rev/7ab1e7cc8f6a
Add a test to test aborting the signal in postTask's callback r=smaug

== Change summary for alert #33900 (as of Fri, 22 Apr 2022 00:12:00 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
64%	office LastVisualChange	windows10-64-shippable-qr	fission warm webrender	1,183.50 -> 425.33
61%	office LastVisualChange	windows10-64-shippable-qr	cold fission webrender	1,876.54 -> 728.08
61%	office LastVisualChange	macosx1015-64-shippable-qr	fission warm webrender	906.67 -> 353.33
59%	office LastVisualChange	macosx1015-64-shippable-qr	cold fission webrender	1,516.67 -> 626.67
45%	office loadtime	linux1804-64-shippable-qr	fission warm webrender	413.42 -> 226.67
...	...	...	...	...
12%	office fcp	macosx1015-64-shippable-qr	cold fission webrender	468.17 -> 409.71

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=33900

Comment 18

[Olli Pettay [:smaug][[e-mail]](vacation until Nov 16)]

Interesting. Does office use the scheduler API and if the browser doesn't have it, they have some badly implemented JS wrapper for it
(since scheduler API doesn't really add anything which couldn't be done using other APIs).

Comment 19

[Alexandru Ionescu (needinfo me) [:alexandrui]]

(In reply to Pulsebot from comment #14)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ab87d3254a13
Prototype the Prioritized Task Scheduling API r=smaug
https://hg.mozilla.org/integration/autoland/rev/e5a0ef58ae70
Allow some timeouts not to clamp in workers r=smaug
https://hg.mozilla.org/integration/autoland/rev/0713b093b0a6
Fix some failures related to the new interfaces that are introduced by the
Scheduling API r=smaug
https://hg.mozilla.org/integration/autoland/rev/60c9527ee051
Fix the setPriority-delayed-task test in Firefox r=smaug
https://hg.mozilla.org/integration/autoland/rev/f1b93e2426fe
Enable WPT for the Prioritized Task Scheduling API r=smaug
https://hg.mozilla.org/integration/autoland/rev/64d6672ab0f5
Don't reduce timer precision for post-task-delay.any.js r=smaug
https://hg.mozilla.org/integration/autoland/rev/a440fb0e93f1
Add a test to test aborting the signal in postTask's callback r=smaug

== Change summary for alert #33927 (as of Mon, 25 Apr 2022 17:09:33 GMT) ==

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
81%	office loadtime	linux1804-64-shippable-qr	fission warm webrender	226.74 -> 411.08
75%	office loadtime	linux1804-64-shippable-qr	cold fission webrender	442.28 -> 774.04
55%	office fcp	linux1804-64-shippable-qr	fission warm webrender	253.14 -> 392.79
21%	office fcp	linux1804-64-shippable-qr	cold fission webrender	481.04 -> 583.46

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=33927

Comment 20

[Sean Feng [:sefeng]]

So apparently due to a bug in our code, office didn't get loaded correctly, so we got the improvement.

With the fix (bug 1766059), the improvement got reverted back to normal.

Comment 21

[Hamish Willee]

FF101 docs work for this can be tracked in https://github.com/mdn/content/issues/15468

Most of this is complete/waiting review in https://github.com/mdn/content/pull/15978. Feedback welcome.