1920115 - Prototype Scheduler.yield

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[Sean Feng [:sefeng]]

https://wicg.github.io/scheduling-apis/#dom-scheduler-yield

I have a half baked patch, need to finish it.

Comment 1

[Sean Feng [:sefeng]]

Attachment: Bug 1920115 - Refactor TaskSignal to avoid a circular header dependency in the following patches r=#dom-core,jjaschke

Comment 2

[Sean Feng [:sefeng]]

Attachment: Bug 1920115 - Add the setup for WebTaskSchedulingState r=#dom-core,jjaschke

Spec: https://wicg.github.io/scheduling-apis/#scheduling-state

This patch add the setup for WebTaskSchedulingState so that it
can be set and get in the following patch, by allowing it
to be carried over in continued Promise callbask and be set to
window globals and worker globals.

Comment 3

[Sean Feng [:sefeng]]

Attachment: Bug 1920115 - Implement scheduler.yield r=#dom-core,jjaschke

Spec: https://wicg.github.io/scheduling-apis/#dom-scheduler-yield

Comment 4

[Sean Feng [:sefeng]]

Attachment: Bug 1920115 - Update the ini files for scheduler.yield accordingly r=#dom-core,jjaschke

Comment 5

[Sean Feng [:sefeng]]

Attachment: Bug 1920115 - Allow selecting tasks from all existing web schedulers for main thread

This is a missing step in the current implementation. When we about
to select a task, it should pick one from all scheduled tasks, including
the ones scheduled by different schedulers.

Comment 6

[Sean Feng [:sefeng]]

Attachment: Bug 1920115 - Allow high priority tasks to run before timers

In Gecko, unlike other runnables where the TaskController
picks one each at a time, the TimeoutManager allows multiple
timers to run sequentially without allowing other runnables
to run in between.

This patch makes the user_blocking and user_visible tasks
dispatched by Scheduler API can run before timers.

Comment 7

[Sean Feng [:sefeng]]

Attachment: Bug 1920115 - Allow higher priority web scheduler scheduled tasks to run before timers for workers

Comment 8

[Sean Feng [:sefeng]]

Attachment: Bug 1920115 - Fix a bug where AbortController doesn't abort scheduler.yield

Instead of passing a single AbortSignal argument to CreateTask,
we now separate it into a AbortSignal and a TaskSignal. They
could be the same when TaskController is used, and if its
AbortController, only AbortSignal is non-null.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6b23965ce57e
Refactor TaskSignal to avoid a circular header dependency in the following patches r=jjaschke,dom-core
https://hg.mozilla.org/integration/autoland/rev/121bf804d2a6
Add the setup for WebTaskSchedulingState r=jjaschke,dom-core,arai
https://hg.mozilla.org/integration/autoland/rev/be6c223e63f0
Implement scheduler.yield r=jjaschke,dom-core,webidl,smaug
https://hg.mozilla.org/integration/autoland/rev/6c1140811a6c
Update the ini files for scheduler.yield accordingly r=jjaschke,dom-core
https://hg.mozilla.org/integration/autoland/rev/7522970c5a1d
Allow selecting tasks from all existing web schedulers for main thread r=jjaschke,smaug
https://hg.mozilla.org/integration/autoland/rev/4ccb6970887e
Allow high priority tasks to run before timers r=smaug
https://hg.mozilla.org/integration/autoland/rev/6a8cb3cc704e
Allow higher priority web scheduler scheduled tasks to run before timers for workers r=smaug
https://hg.mozilla.org/integration/autoland/rev/f5357c6c5580
Fix a bug where AbortController doesn't abort scheduler.yield r=smaug

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/50908 for changes under testing/web-platform/tests

Comment 11

[agoloman]

Backed out for causing hazard bustages @CycleCollectedJSContext.cpp.

• Backout link
• Push with failures
• Failure Log

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/912cf1adac80
Refactor TaskSignal to avoid a circular header dependency in the following patches r=jjaschke,dom-core
https://hg.mozilla.org/integration/autoland/rev/78181c32bdc6
Add the setup for WebTaskSchedulingState r=jjaschke,dom-core,arai
https://hg.mozilla.org/integration/autoland/rev/79b3b0148eb4
Implement scheduler.yield r=jjaschke,dom-core,webidl,smaug
https://hg.mozilla.org/integration/autoland/rev/4b579a1c9b46
Update the ini files for scheduler.yield accordingly r=jjaschke,dom-core
https://hg.mozilla.org/integration/autoland/rev/0773f669c498
Allow selecting tasks from all existing web schedulers for main thread r=jjaschke,smaug
https://hg.mozilla.org/integration/autoland/rev/4739af17e757
Allow high priority tasks to run before timers r=smaug
https://hg.mozilla.org/integration/autoland/rev/67bf260fe59b
Allow higher priority web scheduler scheduled tasks to run before timers for workers r=smaug
https://hg.mozilla.org/integration/autoland/rev/2d0905a92f2c
Fix a bug where AbortController doesn't abort scheduler.yield r=smaug

Comment 14

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/912cf1adac80
https://hg.mozilla.org/mozilla-central/rev/78181c32bdc6
https://hg.mozilla.org/mozilla-central/rev/79b3b0148eb4
https://hg.mozilla.org/mozilla-central/rev/4b579a1c9b46
https://hg.mozilla.org/mozilla-central/rev/0773f669c498
https://hg.mozilla.org/mozilla-central/rev/4739af17e757
https://hg.mozilla.org/mozilla-central/rev/67bf260fe59b
https://hg.mozilla.org/mozilla-central/rev/2d0905a92f2c

Comment 15

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/991d6e612ec2
Backed out 8 changesets for causing multiple failures.

Comment 16

[Serban Stanca [:SerbanS]]

Backed out for causing multiple failures.

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/dom/webscheduling/WebTaskScheduler.h:107:7: error: control reaches end of non-void function [-Werror=return-type]

Also, please check these wpt failures. It only fails on Windows 11 x64 24H2 opt and also fails in other forms, as it can be seen here.

Comment 17

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cfae5efaae37
Refactor TaskSignal to avoid a circular header dependency in the following patches r=jjaschke,dom-core
https://hg.mozilla.org/integration/autoland/rev/f441cb5e7e6e
Add the setup for WebTaskSchedulingState r=jjaschke,dom-core,arai
https://hg.mozilla.org/integration/autoland/rev/bffd879a7547
Implement scheduler.yield r=jjaschke,dom-core,webidl,smaug
https://hg.mozilla.org/integration/autoland/rev/2b4f7ebdb0b7
Update the ini files for scheduler.yield accordingly r=jjaschke,dom-core
https://hg.mozilla.org/integration/autoland/rev/41d90165c19a
Allow selecting tasks from all existing web schedulers for main thread r=jjaschke,smaug
https://hg.mozilla.org/integration/autoland/rev/134228f242de
Allow high priority tasks to run before timers r=smaug
https://hg.mozilla.org/integration/autoland/rev/6934fa78ea13
Allow higher priority web scheduler scheduled tasks to run before timers for workers r=smaug
https://hg.mozilla.org/integration/autoland/rev/00dc9f4af854
Fix a bug where AbortController doesn't abort scheduler.yield r=smaug

Comment 19

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/cfae5efaae37
https://hg.mozilla.org/mozilla-central/rev/f441cb5e7e6e
https://hg.mozilla.org/mozilla-central/rev/bffd879a7547
https://hg.mozilla.org/mozilla-central/rev/2b4f7ebdb0b7
https://hg.mozilla.org/mozilla-central/rev/41d90165c19a
https://hg.mozilla.org/mozilla-central/rev/134228f242de
https://hg.mozilla.org/mozilla-central/rev/6934fa78ea13
https://hg.mozilla.org/mozilla-central/rev/00dc9f4af854

Comment 20

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 21

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged

Comment 22

[Hamish Willee]

FF139 MDN docs work for this can be tracked in https://github.com/mdn/content/issues/39310. Mostly a browser compatibility data update and release note/experimental features doc update.