1735124 - Make QM_TRY stacks thread-aware

Status: RESOLVED FIXED

(Core :: Storage: Quota Manager, task)

Description

[Jens Stutte [:jstutte]]

The sequence number is currently per-process , and we don't record the thread id. We should record a pair of thread id and thread-local sequence number.

This translates into:

• having thread-specific sequence counters
• write out the thread_id

To avoid effort in adjusting the python scripts, we might consider to mangle the thread id with the thread sequence number to have just one seq id, like ((thread_id << 32) | (thread_seq & 0xffffffff)).

Comment 1

[Harveer Singh]

Attachment: Bug 1735124: sequence field in QM_TRY stack propagation now contains seq_no and thread_id information, r=#dom-storage-reviewers,jstutte

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/99502a67f326
sequence field in QM_TRY stack propagation now contains seq_no and thread_id information, r=jstutte,dom-storage-reviewers

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/99502a67f326

Comment 4

[Harveer Singh]

With my last commit, I started the sequence number counter started at 0 which caused some issues with the python scripts. I need to change the sequence counter number to start at 1 and it used to be like that prior to my change.

Comment 5

[Harveer Singh]

Attachment: Bug 1735124: Start the sequence number in QM_TRY logging at 1. r=jstutte,jkrause

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f52c39eaa11b
Start the sequence number in QM_TRY logging at 1. r=jstutte

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/f52c39eaa11b

Comment 8

[Jan Rio Krause]

The python scripts located in dom/quota/scripts also need to be adapted.

Comment 9

[Jan Rio Krause]

Attachment: Bug 1735124 - Include `thread_id` in row order and extract `seq` from merged value. r=#dom-storage-reviewers

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c78ac4ebf32b
Include `thread_id` in row order and extract `seq` from merged value. r=dom-storage-reviewers,jstutte

Comment 11

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/c78ac4ebf32b