Open Bug 1735262 Opened 4 years ago Updated 4 years ago

Layout module should stop using `int32_t` as offset in DOM node

Categories

(Core :: Layout, task)

task

Tracking

()

People

(Reporter: masayuki, Unassigned)

References

Details

After fixing bug 1729170, if nsTextFrame and nsSkipCharsRunIterator can use uint32_t for treating offset/length of text (i.e., we can get rid of ugly casts). Note that offset in text is always less than INT32_MAX, but DOM API manages it with uint32_t. Therefore, using uint32_t makes things simpler.

I realized that it's impossible to change only nsTextFrame and NsSkipCharsRunIterator since nsIFrame has some API to return signed offset.

Component: Layout: Text and Fonts → Layout
Summary: nsTextFrame and nsSkipCharsRunIterator should use `uint32_t` for text offset/length instead of `int32_t` → Layout module should stop using `int32_t` as offset in DOM node
You need to log in before you can comment on or make changes to this bug.