1735353 - Handle edited messages in logs

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, task)

Description

[Martin Giger [:freaktechnik]]

When a message sent by a user edited with a new version also sent by a user, we should handle this in logs, too.

Comment 1

[Patrick Cloke [:clokep]]

This very much makes me wish we had a more standard interface for interacting with the log files. I suspect we're going to need to do something that lets you "replay" the interaction, as opposed to actually modifying the data (since logs are meant to be append-only). I'm unsure if this is "good" since it preserves all of the data or "bad" because it preserves all of the data. :)

Comment 2

[Martin Giger [:freaktechnik]]

Since I've been treating edited messages and deleted messages similar on the "real time side", I'll add this here (it's possible I've mentioned it somewhere else already):

For deleted messages we currently put a flag in the logs to indicate a message would be deleted plus we preserve the remoteId. To avoid re-writing log files too often, I instead propose to have some kind of "log file maintenance" that would remove deleted messages during idle times. As such, we'd have to save which log files have unprocessed delete instructions. This should, of course be toggleable with a pref, in case someone really wants to keep everything they ever received. However, I would argue for defaulting it to be enabled, since moderation will often be done with deletions and you might not want whatever was deleted to show up in a full text search of your local data...

Comment 3

[Martin Giger [:freaktechnik]]

Attachment: Bug 1735353 - Properly handle deleted messages in logs and add tests for delete and edit. r=clokep

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ab3c7828e255
Properly handle deleted messages in logs and add tests for delete and edit. r=clokep

Comment 5

[Martin Giger [:freaktechnik]]

Attachment: Bug 1735353 - Remove deleted message contents from log files. r=clokep

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/36dd0b9be653
Remove deleted message contents from log files. r=clokep