1735368 - Fix browser_auto_close_window.js so it passes when download improvements are enabled

Status: RESOLVED FIXED

(Firefox :: Downloads Panel, task, P1)

Description

[:Gijs (he/him)]

This test is failing because it expects a dialog and one doesn't appear.

Making the dialog appear is trivial but we also need to make sure that blank tabs still get closed even when the dialog is not opened.

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1735368 - fix browser_auto_close_window.js so it passes with download improvements enabled and when asking for all downloads, r?sfoster

Comment 2

[:Gijs (he/him)]

Attachment: Bug 1735368 - ensure we also test saving closing windows when saving downloads to disk, r?sfoster

Depends on D128628

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/609299c8386b
fix browser_auto_close_window.js so it passes with download improvements enabled and when asking for all downloads, r=sfoster
https://hg.mozilla.org/integration/autoland/rev/76af648f5fb2
ensure we also test saving closing windows when saving downloads to disk, r=sfoster

Comment 4

[Noemi Erli[:noemi_erli]]

Backed out 2 changesets (Bug 1735368) for causing failures in browser_extension_correction.js

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=dQ7nQ5evRomwxGNyTje8RQ.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=76af648f5fb2e1da269ee9c2c3bc83f8b2ccc375

Log: https://treeherder.mozilla.org/logviewer?job_id=355104336&repo=autoland&lineNumber=3680

Backout: https://hg.mozilla.org/integration/autoland/rev/240cc3419bc9b1783a2baf2fa4d0868d2837344c

Comment 5

[:Gijs (he/him)]

Ugh, I'm such an idiot sometimes. Filed bug 1736467 for the particular way in which I was an idiot this time.

Comment 6

[:Gijs (he/him)]

https://treeherder.mozilla.org/jobs?repo=try&revision=9323cb11f9d2bc3028b6b0c9af0e32d495d0576e

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/40949eacf691
fix browser_auto_close_window.js so it passes with download improvements enabled and when asking for all downloads, r=sfoster
https://hg.mozilla.org/integration/autoland/rev/8996512a44a4
ensure we also test saving closing windows when saving downloads to disk, r=sfoster

Comment 8

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/40949eacf691
https://hg.mozilla.org/mozilla-central/rev/8996512a44a4