1735423 - [wpt-sync] Sync PR 31209 - content-visibility: Improve interactions with top layer.

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 31209 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31209
Details from upstream follow.

Vladimir Levin <[e-mail]> wrote:

content-visibility: Improve interactions with top layer.

When an element is added to top layer, and the content-visibility
ancestor prevents it from being drawn, then this patch ensures that the
element in the top layer does not get a layout object unless the
content-visibility lock is removed.

This is done as follows

• layout tree is detached when an element is added to top layer while
  under a c-v subtree
• we don't store computed style (thus don't create layout objects) on
  top layer locked elements
• when removing the lock, we dirty either the path from the top layer
  to the lock for style recalc or we cause the lock to do a full
  descedant recalc if we can't dirty style.

R=[e-mail], [e-mail], [e-mail]

Bug: 1251166
Change-Id: I93b4157ba3d67993175a93835c303faaa7f3d1c4
Reviewed-on: https://chromium-review.googlesource.com/3217939
WPT-Export-Revision: 927be8f59a266d9195ecc3e9fca630b6cde65fb9

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=36bcbc6c2b12fc3f93ed118b777ac68c640ffe50

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 5 tests

Status Summary

Firefox

PASS : 2
FAIL : 3

Chrome

PASS : 3
FAIL : 2

Safari

TIMEOUT: 5

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-contain/content-visibility/content-visibility-with-top-layer-000.tentative.html: FAIL (Chrome: PASS, Safari: TIMEOUT)
/css/css-contain/content-visibility/content-visibility-with-top-layer-001.tentative.html: FAIL (Chrome: PASS, Safari: TIMEOUT)
/css/css-contain/content-visibility/content-visibility-with-top-layer-002.tentative.html: FAIL (Chrome: FAIL, Safari: TIMEOUT)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/76c741415e48
[wpt PR 31209] - content-visibility: Improve interactions with top layer., a=testonly
https://hg.mozilla.org/integration/autoland/rev/82a21f3abb61
[wpt PR 31209] - Update wpt metadata, a=testonly

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/76c741415e48
https://hg.mozilla.org/mozilla-central/rev/82a21f3abb61