1735458 - New mail alert should not be displayed when running a full-screen application

Status: RESOLVED FIXED

(Thunderbird :: OS Integration, defect)

Description

[The_Assimilator]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Waterfox/78.13.0

Steps to reproduce:

It appears that with the recent, wholly unnecessary UI redesign, bug #499557 has resurfaced.

Actual results:

See #499557.

Expected results:

See #499557.

Comment 1

[Ping Chen [:rnons] (away)]

Attachment: Bug 1735458 - Do not show mail notification on Windows if running fullscreen app. r=mkmelin

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a3215bf459e2
Do not show mail notification on Windows if running fullscreen app. r=mkmelin

Comment 3

[Magnus Melin [:mkmelin]]

Windows bct5 seem to be perma failing: comm/mail/test/browser/notification/browser_notification.js I'd think due to this?
Started try with backout now: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=daa7f16e92e5d7ac8ae85a32c4bb0b2d088251ce

Comment 4

[Magnus Melin [:mkmelin]]

Backout: https://hg.mozilla.org/comm-central/rev/3cb001c0e28b958347beba1fa869adaa46776848

Comment 5

[Intermittent Failures Robot]

3 failures in 3315 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 3

Platform and build breakdown:

• linux64: 1
  • opt: 1
• windows7-32-qr: 2
  • opt: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1735458&startday=2021-10-11&endday=2021-10-17&tree=all

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3a1a2fe632c7
Do not show mail notification on Windows if running fullscreen app. r=mkmelin

Comment 7

[Ping Chen [:rnons] (away)]

Comment on attachment 9245835 [details]
Bug 1735458 - Do not show mail notification on Windows if running fullscreen app. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): bug 715799
User impact if declined: Mail notification on Windows is shown even when running fullscreen app
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): low

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9245835 [details]
Bug 1735458 - Do not show mail notification on Windows if running fullscreen app. r=mkmelin

[Triage Comment]
Approved for beta

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 94.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/1bd075d2d377

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9245835 [details]
Bug 1735458 - Do not show mail notification on Windows if running fullscreen app. r=mkmelin

[Triage Comment]
approved for esr91

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 91.3.1:
https://hg.mozilla.org/releases/comm-esr91/rev/3416ba4648f8