1735614 - Building initial save visible / save full page UI in the tab modal

Status: VERIFIED FIXED

(Firefox :: Screenshots, task, P2)

Description

[Sam Foster [:sfoster] (he/him)]

Add the 2 buttons to our tab modal and hook them up to preview and save/copy screenshots of the visible viewport and the full page.

Comment 1

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1735614 - Building initial save visible / save full page UI in the tab modal. r=sfoster!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1884a0785032
Building initial save visible / save full page UI in the tab modal. r=sfoster

Comment 3

[Atila Butkovits]

Backed out for causing failures at browser_all_files_referenced.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/5fc0bcd09aa42b24d2d637ac2a1c61c71085764e

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=eeWfaa5qTsiwcI-F_Amo3A.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=1884a0785032e8c31f046255d9331d7c4d6f3ff4

Failure log: https://treeherder.mozilla.org/logviewer?job_id=356911749&repo=autoland&lineNumber=2918

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc971fd1cebc
Building initial save visible / save full page UI in the tab modal. r=sfoster

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/dc971fd1cebc

Comment 6

[Giorgia Nichita, Release Desktop QA]

@Niklas, if you have time could you please help me understand what exactly are the changes here and how can I verify this fix?

Comment 7

[Niklas Baumgardner [:niklas]]

(In reply to Giorgia Nichita, Release Desktop QA from comment #6)

@Niklas, if you have time could you please help me understand what exactly are the changes here and how can I verify this fix?

With the screenshots.browser.component.enabled set to true taking a screenshot will open a panel in the top right corner of the browser.
You can open the panel with the toolbar button, context menu and shortcut.

Comment 8

[Giorgia Nichita, Release Desktop QA]

Thank you Niklas!
Verified as fixed on 96.0b5 (20211214203716) on Ubuntu 20.04, macOS 10.15 and Windows 10 x64.