1735717 - Add a way for getting information about total disk space (disk capacity)

Status: RESOLVED FIXED

(Core :: XPCOM, task, P1)

Description

[Jan Varga [:janv]]

We need to change our temporary storage calculation to use total disk space instead of free disk space. However, there's currently no nsIFile attribute/method which could be used for this, so we need to add a new readonly attribute, for example diskSpaceTotal.

Comment 1

[Thorin [:thorin]]

don't forget Bug 315278 :)

Comment 2

[Jan Varga [:janv]]

Attachment: Bug 1735717 - Add a way for getting information about total disk space (disk capacity); r=#dom-storage

Comment 3

[Jens Stutte [:jstutte]]

I am not sure about the dependency cycle here. For sure we need bug 1740212 for bug 1735713, and the patches there depend on the patches here, IIUC. On the other hand, the entire functionality "Add a way for getting information about total disk space (disk capacity)" is only complete with bug 1740212 so this bug should depend on it. I assume the only way to get out of this loop would be to have another "Implement nsLocalFile::GetDiskCapacity on Linux/Mac" bug (splitting the patch here) and make this bug depend on both and the Windows bug on that one.

But we might just want to review all of that together and land it, rather than adjust dependencies.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de2894087f66
Add a way for getting information about total disk space (disk capacity); r=dom-storage-reviewers,jari,xpcom-reviewers,nika

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/de2894087f66