1735907 - Calendars refresh when going from offline to online, even if set to manual refresh only

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[Geoff Lankow (:darktrojan)]

If you have a calendar set to refresh only when you tell it to, it should not refresh when changing from offline to online.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1735907 - When online state changes, don't refresh disabled calendars or calendars set to manual refresh only. r=mkmelin

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/9ba315cc69da
When online state changes, don't refresh disabled calendars or calendars set to manual refresh only. r=mkmelin

Comment 3

[Geoff Lankow (:darktrojan)]

Comment on attachment 9246024 [details]
Bug 1735907 - When online state changes, don't refresh disabled calendars or calendars set to manual refresh only. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): not a regression
User impact if declined: outgoing connection attempted when it shouldn't be
Testing completed (on c-c, etc.): landed last week
Risk to taking this patch (and alternatives if risky): low

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9246024 [details]
Bug 1735907 - When online state changes, don't refresh disabled calendars or calendars set to manual refresh only. r=mkmelin

[Triage Comment]
Approved for beta

Comment 5

[Rob Lemley [:rjl]]

Thunderbird 94.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/94ae755d750a

Comment 6

[Geoff Lankow (:darktrojan)]

Comment on attachment 9246024 [details]
Bug 1735907 - When online state changes, don't refresh disabled calendars or calendars set to manual refresh only. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): not a regression
User impact if declined: outgoing connection attempted when it shouldn't be
Testing completed (on c-c, etc.): in 94b4
Risk to taking this patch (and alternatives if risky): low

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9246024 [details]
Bug 1735907 - When online state changes, don't refresh disabled calendars or calendars set to manual refresh only. r=mkmelin

[Triage Comment]
Approved for esr91

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 91.3.0:
https://hg.mozilla.org/releases/comm-esr91/rev/7c5326a36da0