1735947 - Title bar in Nightly 95.0a1 (2021-10-14) using macOS has incorrect height when in full-screen mode

Status: RESOLVED DUPLICATE of bug 1736522

(Core :: Widget: Cocoa, defect, P2)

Description

[Mark Koskei :mkipyegon]

Attachment: Screenshot 2021-10-15 at 04.18.42.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:94.0) Gecko/20100101 Firefox/94.0

Steps to reproduce:

Using Firefox Nightly 95.0a1 (2021-10-14) on macOS 10.15.7, I entered full-screen mode.

Actual results:

The height of the title bar is larger than expected.

Expected results:

The height of the title bar should be the same as the traffic light symbols.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Cocoa' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Stephen A Pohl [:spohl]]

Are you still experiencing this issue? If so, could you clarify when you experience this? Is it after you go into fullscreen and then move the mouse to the top of the screen to display the Apple menu bar? Or are there other steps to reproduce?

Comment 3

[Mark Koskei :mkipyegon]

(In reply to Stephen A Pohl [:spohl] from comment #2)

Are you still experiencing this issue?

I'm still experiencing the same behaviour with the current version of Nightly, (2021-10-21).

Is it after you go into fullscreen and then move the mouse to the top of the screen to display the Apple menu bar?

Yes. These are the only steps required.

Comment 4

[Stephen A Pohl [:spohl]]

Could you run mozregression[1] to see when this started happening? You could either use the GUI version availabe at https://mozilla.github.io/mozregression/, or run it via Terminal. To run it via Terminal, simply run these three commands in a Terminal window:

sudo easy_install pip
sudo python3 -m pip install -U mozregression --ignore-installed
mozregression --good 2017-01-01

A number of Firefox versions will open in succession to narrow down when this started occurring. Simply type "good" or "bad" in Terminal based on whether or not a build reproduces the bug. Once finished, please post the output from the last run. It should give a last good and first bad revision as well as a link to look at the changesets in that range. Thank you!

[1] https://mozilla.github.io/mozregression/

Comment 5

[Mark Koskei :mkipyegon]

Done. This was the output.

25:57.76 INFO: Narrowed integration regression window from [9d0f1fc9, 9785ceff] (3 builds) to [cc067906, 9785ceff] (2 builds) (~1 steps left)
25:57.76 INFO: No more integration revisions, bisection finished.
25:57.76 INFO: Last good revision: cc067906622d2660d8eda3b6abe1c71d4a8e102a
25:57.76 INFO: First bad revision: 9785ceff3f61c52823d82b3f217b4897bcebaad3
25:57.76 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=cc067906622d2660d8eda3b6abe1c71d4a8e102a&tochange=9785ceff3f61c52823d82b3f217b4897bcebaad3

Comment 6

[Stephen A Pohl [:spohl]]

Thank you for tracking this down!

Comment 7

[Emilio Cobos Álvarez (:emilio)]

I don't see this locally on Monterrey beta, but is it fixed by bug 1736522? Stephen, if you can repro can you try to import that patch and check?

Comment 8

[Stephen A Pohl [:spohl]]

I haven't been able to reproduce this myself. Do you happen to have a try build with bug 1736522 applied that Mark could test?

Comment 9

[Emilio Cobos Álvarez (:emilio)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e7e336e4ddaceebbb1e1b5f25f50dafcd4299395 should have builds in a bit. I'm moderately sure it should fix it, but let's see...

Comment 10

[Stephen A Pohl [:spohl]]

Thanks, Emilio! Mark, could you try this build and tell us if you're still experiencing this issue?

https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/IXv2NLbJSR2nCMKF6sbzCg/runs/0/artifacts/public/build/target.dmg

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1735318

Comment 12

[Mark Koskei :mkipyegon]

(In reply to Stephen A Pohl [:spohl] from comment #10)

Thanks, Emilio! Mark, could you try this build and tell us if you're still experiencing this issue?

I can confirm this build does not have the issue that I was experiencing.

Comment 13

[Emilio Cobos Álvarez (:emilio)]

Thanks for checking!