1735983 - Issue with Euro Symbol (€) in Mail Account Password

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect, P5)

Description

[Schorschii]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/94.0.4606.81 Safari/537.36

Steps to reproduce:

I tried to set up an IMAP account with a password which contains a Euro (€) symbol.

Actual results:

On TB 78.13 (shipped by the current Ubuntu 20.04 repos) nothing happens when clicking the "Next" button.
On TB 91, the following error appears: "TypeError: Base64Encode: Cannot convert value to ByteString because the character at index 26 has value 8364 which is greater than 255."

Expected results:

TB should accept passwords with € characters. The same password works in other clients such as Outlook or Evolution.

Comment 1

[newsfan]

Password with §£ works here for IMAP, but the account was set up before TB 91. Is the issue during account setup or in normal operation? If it's in account setup, can you correct the password later in the security preferences or enter it when prompted?
BTW: The TypeError is from the console, right? Which source file and line?

Comment 2

[Schorschii]

Attachment: Bildschirmfoto vom 2021-10-16 13-59-32.png

Comment 3

[Schorschii]

Thanks for your response. This error message is visible during the account setup in the GUI of TB 91 (not on the console), I've attached a screenshot. It also affects older version including TB 78, but there is no error message visible, just nothing happens when clicking the "Next" button.

Thanks for this workaround. I now entered a wrong password and then I was able to set the correct password with € char in the security preferences. After that, everything works fine. So this seems to be a bug specific to the initial account setup page.

Comment 4

[newsfan]

The bug is here:
https://searchfox.org/comm-central/rev/89632cecb2845b88ff87b9f09c8cfd47a1fe886a/mail/components/accountcreation/FetchHTTP.jsm#217
Before using btoa() the username and password need to be converted to UTF-8.
The code originally comes from here https://hg.mozilla.org/comm-central/rev/1403c0fa3d1a#l8.209 from bug 1500105.
Funny that no one noticed in three years.

Comment 5

[Ben Bucksch (:BenB)]

Thanks, newsfan!

Comment 6

[Ben Bucksch (:BenB)]

Sorry, this dropped from my radar. I ping would have been sufficient. I can take care of this.

Comment 7

[Magnus Melin [:mkmelin]]

Attachment: Bug 1735983 - Cannot set up account if Euro Symbol (€) in Mail Account Password. r=aleca

Comment 8

[Magnus Melin [:mkmelin]]

No need, I had created the patch already.

Comment 9

[Ben Bucksch (:BenB)]

Thanks, Magnus

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/08847f61ffa5
Cannot set up account if Euro Symbol (€) in Mail Account Password. r=aleca

Comment 11

[Magnus Melin [:mkmelin]]

Comment on attachment 9252872 [details]
Bug 1735983 - Cannot set up account if Euro Symbol (€) in Mail Account Password. r=aleca

[Approval Request Comment]
Regression caused by (bug #): bug 1500105
User impact if declined: cannot set up account is e.g. € in the password
Testing completed (on c-c, etc.): c-c, beta
Risk to taking this patch (and alternatives if risky): safe

Comment 12

[Wayne Mery (:wsmwk)]

Comment on attachment 9252872 [details]
Bug 1735983 - Cannot set up account if Euro Symbol (€) in Mail Account Password. r=aleca

[Triage Comment]
Approved for esr91

Comment 13

[Rob Lemley [:rjl]]

Thunderbird 91.4.1:
https://hg.mozilla.org/releases/comm-esr91/rev/adec9e0023bf