1736017 - Unify intl/locale/MozLocale and intl/components/Locale

Status: RESOLVED FIXED

(Core :: Internationalization, task, P3)

Description

[Dan Minor [:dminor]]

Bug 1719746 moved the LanguageTag implementation from SpiderMonkey to mozilla::intl::Locale. Unfortunately, we also have a mozilla:intl::Locale class in intl/Locale/MozLocale.h. This lead to crashes due to the wrong destructor being called!

To workaround this, I renamed the MozLocale version to mozilla::intl::Locale in Bug 1719746. This bug tracks unifying the two implementations.

Comment 1

[Dan Minor [:dminor]]

Attachment: Bug 1736017 - Replace MozLocale with Locale in nsLineBreaker.cpp; r=#platform-i18n-reviewers!

Comment 2

[Dan Minor [:dminor]]

Attachment: Bug 1736017 - Replace MozLocale with Locale in PaymentRequest.cpp; r=#platform-i18n-reviewers

Depends on D129205

Comment 3

[Dan Minor [:dminor]]

Attachment: Bug 1736017 - Replace MozLocale with Locale in EditorSpellCheck.cpp; r=#platform-i18n-reviewers

Depends on D129206

Comment 4

[Dan Minor [:dminor]]

Attachment: Bug 1736017 - Replace MozLocale with Locale in gfxPlatformFontList.cpp; r=#platform-i18n-reviewers

Depends on D129207

Comment 5

[Dan Minor [:dminor]]

Attachment: Bug 1736017 - Replace MozLocale with Locale in LocaleService.cpp; r=#platform-i18n-reviewers!

Depends on D129208

Comment 6

[Dan Minor [:dminor]]

Attachment: Bug 1736017 - Replace MozLocale with Locale in Quotes.cpp; r=#platform-i18n-reviewers!

Depends on D129209

Comment 7

[Dan Minor [:dminor]]

Attachment: Bug 1736017 - Replace MozLocale with Locale in nsLanguageAtomService.cpp; r=#platform-i18n-reviewers!

Depends on D129210

Comment 8

[Dan Minor [:dminor]]

Attachment: Bug 1736017 - Replace MozLocale with Locale in OSPreferences_win.cpp; r=#platform-i18n-reviewers!

Depends on D129211

Comment 9

[Dan Minor [:dminor]]

Attachment: Bug 1736017 - Remove MozLocale; r=#platform-i18n-reviewers

Depends on D129212

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/11721cc861b0
Replace MozLocale with Locale in nsLineBreaker.cpp; r=platform-i18n-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/19be73147fcc
Replace MozLocale with Locale in PaymentRequest.cpp; r=platform-i18n-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/c0cef271022d
Replace MozLocale with Locale in EditorSpellCheck.cpp; r=platform-i18n-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/f771265e0930
Replace MozLocale with Locale in gfxPlatformFontList.cpp; r=platform-i18n-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/84ba2cbd596a
Replace MozLocale with Locale in LocaleService.cpp; r=platform-i18n-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/a78125c71b3e
Replace MozLocale with Locale in Quotes.cpp; r=platform-i18n-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/f16572806b0c
Replace MozLocale with Locale in nsLanguageAtomService.cpp; r=platform-i18n-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/7249dec70600
Replace MozLocale with Locale in OSPreferences_win.cpp; r=platform-i18n-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/d7b7427bb29e
Remove MozLocale; r=platform-i18n-reviewers,gregtatum

Comment 11

[Noemi Erli[:noemi_erli]]

Backed out 9 changesets (Bug 1736017) for causing bustages in nsLineBreaker.cpp

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=ZXQP07XZSl2k8fwiYNSfHQ.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=d7b7427bb29ed46ff40d09bfb4cf1f5b5d804ede

Log: https://treeherder.mozilla.org/logviewer?job_id=356254984&repo=autoland&lineNumber=11416

Backout: https://hg.mozilla.org/integration/autoland/rev/4b9b149dc90ecd2f6d786a3f80c6b684b669ac77

Comment 12

[Dan Minor [:dminor]]

Oops, I forgot to try building after I rebased.

Comment 13

[Dan Minor [:dminor]]

I think we need to figure out how we want to handle _ in the LocaleParser in Bug 1738340 before we can land the patches here.

Comment 14

[Dan Minor [:dminor]]

After some local testing and try runs [1] [2] with an assertion added, I don't think we need to solve Bug 1738340 before landing this. The only location in tree where I'm certain we're using _ as a separator is not affected by the patch stack here.

[1] https://treeherder.mozilla.org/jobs?repo=try&revision=76e4d3a021133837594671f112b85be1bea70868
[2] https://treeherder.mozilla.org/jobs?repo=try&revision=1e13e700e4e7604a0b6eff6ab43ff22390b6335c

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8cafb816ae31
Replace MozLocale with Locale in nsLineBreaker.cpp; r=platform-i18n-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/98e29bc1f4fb
Replace MozLocale with Locale in PaymentRequest.cpp; r=platform-i18n-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/31dcf5dbf0b2
Replace MozLocale with Locale in EditorSpellCheck.cpp; r=platform-i18n-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/e16018b57faf
Replace MozLocale with Locale in gfxPlatformFontList.cpp; r=platform-i18n-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/6f6bc4549520
Replace MozLocale with Locale in LocaleService.cpp; r=platform-i18n-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/1055cd0ae3a0
Replace MozLocale with Locale in Quotes.cpp; r=platform-i18n-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/99bdf30baacd
Replace MozLocale with Locale in nsLanguageAtomService.cpp; r=platform-i18n-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/fdf26f350832
Replace MozLocale with Locale in OSPreferences_win.cpp; r=platform-i18n-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/5d984460e274
Remove MozLocale; r=platform-i18n-reviewers,gregtatum

Comment 16

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/8cafb816ae31
https://hg.mozilla.org/mozilla-central/rev/98e29bc1f4fb
https://hg.mozilla.org/mozilla-central/rev/31dcf5dbf0b2
https://hg.mozilla.org/mozilla-central/rev/e16018b57faf
https://hg.mozilla.org/mozilla-central/rev/6f6bc4549520
https://hg.mozilla.org/mozilla-central/rev/1055cd0ae3a0
https://hg.mozilla.org/mozilla-central/rev/99bdf30baacd
https://hg.mozilla.org/mozilla-central/rev/fdf26f350832
https://hg.mozilla.org/mozilla-central/rev/5d984460e274