1736035 - Make the Import/Export dialogs fully themeable

Status: RESOLVED FIXED

(Thunderbird :: Theme, task)

Description

[Richard Marti (:Paenglab)]

The Import/Export dialogs aren't fully themed. Especially the button on bottom don't use our styles.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1736035-import-export-themeable.patch

The migration.xhtml dialog has invisible buttons because messenger.css isn't imported.

On importDialog.xhtml I added a flex to move the bottom buttons to the bottom. On Windows they aren't at the bottom. Screenshot to show the actual behaviour follows.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: import-dialog.png

Screenshot that shows the bottom buttons not on bottom.

Comment 3

[Alessandro Castellani [:aleca]]

Thanks for working on this, but I think we're planning to move this whole dialog into a tab.
Pinging Magnus for confirmation.

Comment 4

[Magnus Melin [:mkmelin]]

Yes, but it's possible that will not happen very soon, so might was well make them themeable until we get there.

Comment 5

[Richard Marti (:Paenglab)]

The invisible buttons is also a TB91 issue.

Comment 6

[Alessandro Castellani [:aleca]]

Comment on attachment 9246143 [details] [diff] [review]
1736035-import-export-themeable.patch

Review of attachment 9246143 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/import/content/importDialog.xhtml
@@ +25,5 @@
>    <script defer="defer" src="chrome://global/content/globalOverlay.js"></script>
>    <script defer="defer" src="chrome://global/content/editMenuOverlay.js"></script>
>    <script defer="defer" src="chrome://messenger-newsblog/content/feed-subscriptions.js"></script>
>    <script defer="defer" src="chrome://messenger/content/importDialog.js"></script>
> +  <script defer="defer" src="chrome://messenger/content/dialogShadowDom.js"></script>

There's an error when opening this dialog:
JavaScript error: chrome://messenger/content/dialogShadowDom.js, line 13: TypeError: can't access property "shadowRoot", document.querySelector(...) is null

This happens because that file doesn't use the `<dialog>` element, therefore we don't need to add the CSS file to the shadowRoot since all the elements used are in the top level HTML.

Comment 7

[Richard Marti (:Paenglab)]

Attachment: 1736035-import-export-themeable.patch

Sorry, not correctly checked if this is needed.

Comment 8

[Alessandro Castellani [:aleca]]

Comment on attachment 9246211 [details] [diff] [review]
1736035-import-export-themeable.patch

Review of attachment 9246211 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.
On Windows 11 the buttons in the import dialog are all the way at the bottom.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/82f2426dc836
Make the Import/Export dialogs fully themeable. r=aleca

Comment 10

[Richard Marti (:Paenglab)]

Comment on attachment 9246211 [details] [diff] [review]
1736035-import-export-themeable.patch

[Approval Request Comment]
User impact if declined: In Import all dialog buttons not cognizable as buttons
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 11

[Richard Marti (:Paenglab)]

Attachment: 1736035-import-export-themeable-ESR.patch

[Approval Request Comment]
User impact if declined: In Import all dialog buttons not cognizable as buttons
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 12

[Wayne Mery (:wsmwk)]

Comment on attachment 9246298 [details] [diff] [review]
1736035-import-export-themeable-ESR.patch

[Triage Comment]
Approved for beta

Comment 13

[Rob Lemley [:rjl]]

Thunderbird 91.2.1:
https://hg.mozilla.org/releases/comm-esr91/rev/50ee552c6671

Comment 14

[Wayne Mery (:wsmwk)]

Comment on attachment 9246211 [details] [diff] [review]
1736035-import-export-themeable.patch

[Triage Comment]
Approved for beta. (for real this time)

Comment 15

[Rob Lemley [:rjl]]

Thunderbird 94.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/703f8eab33a1