Closed Bug 1736035 Opened 3 years ago Closed 3 years ago

Make the Import/Export dialogs fully themeable

Categories

(Thunderbird :: Theme, task)

Tracking

(thunderbird_esr91+ fixed, thunderbird94 fixed)

RESOLVED FIXED
95 Branch
Tracking Status
thunderbird_esr91 + fixed
thunderbird94 --- fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(3 files, 1 obsolete file)

The Import/Export dialogs aren't fully themed. Especially the button on bottom don't use our styles.

The migration.xhtml dialog has invisible buttons because messenger.css isn't imported.

On importDialog.xhtml I added a flex to move the bottom buttons to the bottom. On Windows they aren't at the bottom. Screenshot to show the actual behaviour follows.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9246143 - Flags: review?(alessandro)
Attached image import-dialog.png

Screenshot that shows the bottom buttons not on bottom.

Thanks for working on this, but I think we're planning to move this whole dialog into a tab.
Pinging Magnus for confirmation.

Flags: needinfo?(mkmelin+mozilla)

Yes, but it's possible that will not happen very soon, so might was well make them themeable until we get there.

Flags: needinfo?(mkmelin+mozilla)

The invisible buttons is also a TB91 issue.

Comment on attachment 9246143 [details] [diff] [review]
1736035-import-export-themeable.patch

Review of attachment 9246143 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/import/content/importDialog.xhtml
@@ +25,5 @@
>    <script defer="defer" src="chrome://global/content/globalOverlay.js"></script>
>    <script defer="defer" src="chrome://global/content/editMenuOverlay.js"></script>
>    <script defer="defer" src="chrome://messenger-newsblog/content/feed-subscriptions.js"></script>
>    <script defer="defer" src="chrome://messenger/content/importDialog.js"></script>
> +  <script defer="defer" src="chrome://messenger/content/dialogShadowDom.js"></script>

There's an error when opening this dialog:
JavaScript error: chrome://messenger/content/dialogShadowDom.js, line 13: TypeError: can't access property "shadowRoot", document.querySelector(...) is null

This happens because that file doesn't use the `<dialog>` element, therefore we don't need to add the CSS file to the shadowRoot since all the elements used are in the top level HTML.
Attachment #9246143 - Flags: review?(alessandro)

Sorry, not correctly checked if this is needed.

Attachment #9246143 - Attachment is obsolete: true
Attachment #9246211 - Flags: review?(alessandro)
Comment on attachment 9246211 [details] [diff] [review]
1736035-import-export-themeable.patch

Review of attachment 9246211 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.
On Windows 11 the buttons in the import dialog are all the way at the bottom.
Attachment #9246211 - Flags: review?(alessandro) → review+
Target Milestone: --- → 95 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/82f2426dc836
Make the Import/Export dialogs fully themeable. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED

Comment on attachment 9246211 [details] [diff] [review]
1736035-import-export-themeable.patch

[Approval Request Comment]
User impact if declined: In Import all dialog buttons not cognizable as buttons
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Attachment #9246211 - Flags: approval-comm-beta?

[Approval Request Comment]
User impact if declined: In Import all dialog buttons not cognizable as buttons
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Attachment #9246298 - Flags: approval-comm-esr91?

Comment on attachment 9246298 [details] [diff] [review]
1736035-import-export-themeable-ESR.patch

[Triage Comment]
Approved for beta

Attachment #9246298 - Flags: approval-comm-esr91? → approval-comm-esr91+

Comment on attachment 9246211 [details] [diff] [review]
1736035-import-export-themeable.patch

[Triage Comment]
Approved for beta. (for real this time)

Attachment #9246211 - Flags: approval-comm-beta? → approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: