Closed
Bug 1736251
Opened 3 years ago
Closed 2 years ago
Avoid calling PlacesUtils.tagging.getTagsForURI when creating PlacesBookmarkTags
Categories
(Toolkit :: Places, task, P2)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
109 Branch
| Tracking | Status | |
|---|---|---|
| firefox109 | --- | fixed |
People
(Reporter: daisuke, Assigned: mak)
References
(Blocks 1 open bug)
Details
(Keywords: perf)
Attachments
(1 file)
This is a follow-up bug of bug 1678607.
In bug 1678607, we introduced PlacesBookmarkTags event.
The event needs its tags, we are using PlacesUtils.tagging.getTagsForURI() to get the tags.
But as it accesses DB synchronously, we concern about the performance.
In this bug, we want to find a way to get tags without accessing DB.
|
Assignee | |
Comment 1•3 years ago
|
||
It should be possible to fetch tags when we initially fetch info for the bookmark being modified, and then just update that list with the tags being added or removed.
|
|
Assignee | |
Comment 2•3 years ago
|
||
I will call this a P2 because the I/O performance impact is interesting and should be avoided.
|
|
Assignee | |
Updated•2 years ago
|
Assignee: nobody → mak
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 3•2 years ago
|
||
|
||
Updated•2 years ago
|
Attachment #9303206 -
Attachment description: Bug 1736251 - Avoid calling PlacesUtils.tagging.getTagsForURI in Bookmarks.jsm. r=daisuke → Bug 1736251 - Avoid calling PlacesUtils.tagging.getTagsForURI in Bookmarks.jsm. r=daisuke!
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/99268af99b7c
Avoid calling PlacesUtils.tagging.getTagsForURI in Bookmarks.jsm. r=daisuke
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox109:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 109 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•