1678607 - Add dedicated tags notifications

Status: RESOLVED FIXED

(Toolkit :: Places, task, P3)

Description

[Marco Bonardo [:mak]]

Instead of using onItemChanged("tags") we should have a dedicated notification for tags.

Ideally it could be a simple bookmark-tags-changed notification, passing an up-to-date list of tags, but some analysis should be done to check if the list of tags is something we get for free (or cheap), if it's something the consumer would fetch regardless, or if we'd have to fetch them.
We could also go with tags-added and tags-removed, but it seems more work for consumers if at the same time some is removed and some is added.

The notification should probably derive from the PlacesBookmark event

Comment 2

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1678607: Implement a mechanism to fire bookmark-tags-changed event.

Comment 3

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1678607: Apply bookmark-tags-changed event.

Depends on D128326

Comment 4

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1678607: Make BookmarkTagsChanged event have tags.

Depends on D128327

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2688fa3d2bc2
Implement a mechanism to fire bookmark-tags-changed event. r=mak
https://hg.mozilla.org/integration/autoland/rev/fd3fbf15e95d
Apply bookmark-tags-changed event. r=mak
https://hg.mozilla.org/integration/autoland/rev/bf20be578758
Make BookmarkTagsChanged event have tags. r=mak

Comment 6

[Alexandru Michis [:malexandru]]

Backed out 3 changesets (Bug 1678607) for causing bc failures in browser_bookmark_add_tags.js
Backout link: https://hg.mozilla.org/integration/autoland/rev/1b6f0e11b8bbd98662242c7f9a141c08bfce516b
Push with failures, failure log.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7705a6b69701
Implement a mechanism to fire bookmark-tags-changed event. r=mak
https://hg.mozilla.org/integration/autoland/rev/13868a361ad3
Apply bookmark-tags-changed event. r=mak
https://hg.mozilla.org/integration/autoland/rev/63d10a00d256
Make BookmarkTagsChanged event have tags. r=mak

Comment 8

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/7705a6b69701
https://hg.mozilla.org/mozilla-central/rev/13868a361ad3
https://hg.mozilla.org/mozilla-central/rev/63d10a00d256