1736327 - Virtual folder properties dialog (which is not resizeable) is not wide enough to fit text for "Search Online..."

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Camille]

Attachment: virtual folder preferences TB94.0b3.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:93.0) Gecko/20100101 Firefox/93.0

Steps to reproduce:

Right-click on a virtual folder (unified folder) - properties.
The dialog is truncated (see attached screenshot).
I am under windows 11, screen size is 2560x1440. Text ratio is 125% but changing to 100% does not solve the issue.
I ran TB in troubleshooting mode and the issue is still here.

Actual results:

The virtual folder properties dialog is truncated (see attached screenshot).

Expected results:

The dialog should not truncate the content or should be resizable.

Comment 1

[Magnus Melin [:mkmelin]]

Hmm, maybe non en-US only. Probably from https://phabricator.services.mozilla.com/D125375
It looks like the (english) [x] Search online (gives up-to-date results ........) is not giving the window a wider than normal natural width.

Comment 2

[Wayne Mery (:wsmwk)]

Camile, thanks for doing all those tests without being asked :)

This is likely to have wide-ranging impact

Comment 3

[Richard Marti (:Paenglab)]

Attachment: dialog-fixed.png

This could be fixed with adding flex="1". The result would be like on the screenshot.

With shorter locales like English the radios would be no more left aligned. See bottom of the screenshot.

Comment 4

[Alessandro Castellani [:aleca]]

Comment on attachment 9246456 [details]
dialog-fixed.png

I'm okay with this.
Definitely long text should wrap when reaching the limit of a window.

Comment 5

[Richard Marti (:Paenglab)]

Attachment: 1736327-virtual-folder-properties.patch

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/773972ecfc48
Fix the Virtual Folder Properties dialog for locales with long strings. r=aleca

Comment 7

[Camille]

You're welcome Wayne! I am a fan of Thunderbird. Glad to help :)

Comment 8

[Magnus Melin [:mkmelin]]

Thx Camille, we appreciate the help!

Comment 9

[Richard Marti (:Paenglab)]

Comment on attachment 9246484 [details] [diff] [review]
1736327-virtual-folder-properties.patch

[Approval Request Comment]
User impact if declined: on some locales cropped text in virtual folder dialog
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9246484 [details] [diff] [review]
1736327-virtual-folder-properties.patch

[Triage Comment]
Approved for beta. (note to self, this doesn't affect tb91)

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 94.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/0be48e202b2b