1736486 - [rust 1.57] ld.lld: error: undefined symbol: BCryptGenRandom

Status: RESOLVED FIXED

(Firefox Build System :: General, defect, P3)

Description

[Mike Hommey [:glandium]]

[task 2021-10-19T00:40:32.387Z] 00:40:32     INFO -  ld.lld: error: undefined symbol: BCryptGenRandom
[task 2021-10-19T00:40:32.388Z] 00:40:32     INFO -  >>> referenced by /rustc/4e89811b46323f432544f9c4006e40d5e5d7663f\/library\std\src\sys\windows\rand.rs:10
[task 2021-10-19T00:40:32.389Z] 00:40:32     INFO -  >>>               libmozwer_s.a(mozwer_s-b4383626653fb7f4.mozwer_s.7a61e29c-cgu.0.rcgu.o):(std::collections::hash::map::RandomState::new::KEYS::__getit::h53be9d6cad892b99)
[task 2021-10-19T00:40:32.389Z] 00:40:32     INFO -  clang-13: error: linker command failed with exit code 1 (use -v to see invocation)

Comment 1

[Mike Hommey [:glandium]]

This is a very recent regression in rustc, I'm going to see if it can be fixed there.

Comment 2

[Mike Hommey [:glandium]]

It comes from https://github.com/rust-lang/rust/pull/84096, and mozwer is just the first thing this happens with.

Comment 4

[Mike Hommey [:glandium]]

Attachment: Bug 1736486 - Link bcrypt where needed.

rust 1.57's libstd adds a dependency on bcrypt on Windows.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b205316ef5c
Link bcrypt where needed. r=firefox-build-system-reviewers,andi

Comment 6

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/5b205316ef5c

Comment 7

[Mike Hommey [:glandium]]

Comment on attachment 9252423 [details]
Bug 1736486 - Link bcrypt where needed.

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Build failure on Windows with rustc 1.57
• User impact if declined: Downstreams that may be building with a recent rust compiler get a build failure.
• Fix Landed on Version: 96
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Practically speaking, it's NPOTB for us.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9252423 [details]
Bug 1736486 - Link bcrypt where needed.

Approved for 91.5esr.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/236ec0e8b771