1736626 - NV12 IOSurface upload is not aligning the CbCr plane correctly

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Markus Stange [:mstange]]

We suspect that this is the reason why we were seeing artifacts on some hardware configurations when we tried using NV12 IOSurfaces for software-decoded video last time. See bug 1657107 for those artifacts.

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1736626 - Properly align more IOSurface properties. r=jrmuizel

Comment 2

[Markus Stange [:mstange]]

Apparently this doesn't fix the issue. :(

Comment 3

[Markus Stange [:mstange]]

But at least it gets us detachment for software-decoded NV12 video on M1 Macs! I'm not sure which part of the patch is responsible for this.

Without this patch, software-decoded NV12 does not achieve detachment on M1 Macs, see bug 1732677 comment 13.

Chromium likely encountered the same problem, see https://bugs.chromium.org/p/chromium/issues/detail?id=1134712 .

Comment 4

[Markus Stange [:mstange]]

(In reply to Markus Stange [:mstange] from comment #2)

Apparently this doesn't fix the issue. :(

Jeff found the real reason: we were using kIOSurfaceBytesPerElement instead of kIOSurfacePlaneBytesPerElement, i.e. missing the word Plane. He's fixing it in bug 1736670.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4535cfabee0d
Properly align more IOSurface properties. r=jrmuizel

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/4535cfabee0d