1736675 - Tooltips have wrong appearance after switching system dark mode on macOS

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

I bet it's bug 1734716 what caused this.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1736675 - Make sure to only override color-scheme on widgets if the color-scheme property says so. r=mstange

So that when the system changes appearance we respect that automatically.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9246708 [details]
Bug 1736675 - Make sure to only override color-scheme on widgets if the color-scheme property says so. r=mstange

Beta/Release Uplift Approval Request

• User impact if declined: After switching system dark to light mode or vice versa, tooltips might have low contrast on macOS.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: * Open Nightly, hover over a tab and see that the tooltip has appropriate contrast.
• Go to macOS settings and switch to dark mode.
• Hover over the tab again. The tooltip text color is white but the background is light (and should be dark after the patch).
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Minor tweak to the regressing bug.
• String changes made/needed: none

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a74707755934
Make sure to only override color-scheme on widgets if the color-scheme property says so. r=mstange

Comment 4

[Victoria Wang [:victoria]]

Related issue that may be solved by this bug:

On a fresh Nightly on MacOS, when going to about:addons > Themes and enabling Dark theme or any of the bold colorways, the tooltips look white-on-light gray. It fixes itself after Firefox restart, but then I can get the inverse problem of black-on-dark gray tooltips when enabling a light theme.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Yeah that's the same bug.

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/a74707755934

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1734716

Comment 8

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Reproduced the issue with Firefox 95.0a1 (20211017213754) on macOS 10.15 and STR from comment 2.
The issue is verified fixed with Firefox 95.0a1 (20211020093007 ) on macOS 10.15. The tooltips are correctly displayed after switching from Light to Dark theme and vice versa inside macOS settings.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9246708 [details]
Bug 1736675 - Make sure to only override color-scheme on widgets if the color-scheme property says so. r=mstange

Approved for 94.0b9 to avoid shipping a new high-visibility regression to users.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/283baa0c1642

Comment 11

[Alexandru Trif, Desktop Test Engineering [:atrif]]

The issue is no longer reproducing with Firefox 94.0b9 (20211021185848) on macOS 11 ARM and 10.15. Tooltips are correctly displayed after switching from Light to Dark theme and vice versa inside macOS settings.