1734716 - macOS native menupopups don't follow computed color-scheme.

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

See bug 1734655 comment 3.

Markus pointed me to https://searchfox.org/mozilla-central/rev/b847c844adf49013067281d3237e7ada24325a34/widget/cocoa/nsCocoaWindow.mm#551 where we choose to follow the appearance for the window.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1734716 - Make macOS menupopups follow color-scheme. r=mstange,#mac-reviewers

They were following the global appearance of the window.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f5c9905b20c8
Make macOS menupopups follow color-scheme. r=mstange,mac-reviewers

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/f5c9905b20c8

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Harry should we uplift this?

Comment 6

[Harry Twyford]

Comment on attachment 9244945 [details]
Bug 1734716 - Make macOS menupopups follow color-scheme. r=mstange,#mac-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: Mac users with Balanced monochromatic themes will see low-contrast menupopups in panels and the sidebar.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Well-understood patch, narrowly scoped to Mac menupopups.
• String changes made/needed:

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9244945 [details]
Bug 1734716 - Make macOS menupopups follow color-scheme. r=mstange,#mac-reviewers

Approved for 94.0b5.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/4b40dac9eed8