1736680 - Create Legacy ShouldResistFingerPrinting Function

Status: RESOLVED FIXED

(Core :: DOM: Events, enhancement)

Description

A legacy ShouldResistFingerprinting function should be created in order for developers to provide an explanation as to why they are using the 'original' RFP call. As there is a gradual move towards having all of the calls of ShouldResistFingerprinting to a nuanced API that takes into account several features, there are still some areas where a 'legacy' function is needed. In this case, the context of the call is not reviewed, so this legacy function will require developers to provide a reason as to why they are using this call. The intent of this is to have an explanation as to why the developer is using the legacy function call instead of the nuanced one. The implementation of this function will include accepting a char* to provide the explanation of why the developer is using the legacy function as opposed to the nuanced preference.

Comment 1

[Ben]

Attachment: Bug 1736680 - Created and implemented legacy ShouldRFP function to ScreenOrientation. r?tjr

Depends on D128173

Comment 3

[Ben]

Attachment: Bug 1736680 - Created and implemented legacy ShouldRFP function to ScreenOrientation. r?tjr

Depends on D128923

Comment 4

[Ben]

Attachment: Bug 1736680 - Implemented legacy function into ScreenOrientation.cpp due to eventual carry over of ShouldRFP. r?tjr

Depends on D128923

Comment 5

[Ben]

Attachment: Bug 1736680 - Called legacy function into ShouldRFP for ScreenOrientation.cpp. r?tjr

Depends on D131246

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b136064a4a9d
Created and implemented legacy ShouldRFP function to ScreenOrientation. r=tjr

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/b136064a4a9d

Comment 8

[Tom Ritter [:tjr] (OOTO until 9/2)]

Have another patch to land here in the future.

Comment 9

[Ben]

Attachment: Bug 1736680 - Implemented legacy function into ScreenOrientation.cpp due to eventual carry over of ShouldRFP r?tjr

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/45864b98bfb4
Implemented legacy function into ScreenOrientation.cpp due to eventual carry over of ShouldRFP r=tjr

Comment 11

[Cristian Tuns]

Backed out for causing build bustages on ScreenOrientation.cpp

• Backout link
• Push with failures
• Failure Log
• Failure line: builds/worker/checkouts/gecko/dom/base/ScreenOrientation.cpp:601:11: error: ISO C++11 does not allow conversion from string literal to 'char *' [-Werror,-Wwritable-strings]

Comment 12

[Ben]

Attachment: Bug 1736680 - Add a missing const qualified to ShouldRFP char* argument. r?tjr

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34a46db467fb
Add a missing const qualified to ShouldRFP char* argument. r=tjr
https://hg.mozilla.org/integration/autoland/rev/419e8940bbdf
Implemented legacy function into ScreenOrientation.cpp due to eventual carry over of ShouldRFP r=tjr

Comment 14

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/34a46db467fb
https://hg.mozilla.org/mozilla-central/rev/419e8940bbdf

Comment 15

[BugBot [:suhaib / :marco/ :calixte]]

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.