1743486 - more cut over for resistfingerprinting API: UseStandinsForNativeColors and Appwindow

Status: RESOLVED FIXED

(Firefox :: Private Browsing, enhancement)

Description

[ccraig8]

Cutting over both UseStandinsForNativeColors in nsContentUtils.cpp
and Appwindow in Appwindow.cpp for finer grain ResistFingerPrinting
Passing both functions strings to explain usage of legacy RFP function

Comment 1

[ccraig8]

Attachment: Bug 1743486: More Cut over for resistinfingerprinting API: UseStandinsForNativeColors and Appwindow r?tjr

Comment 2

[Tom Ritter [:tjr]]

I'm going to try to land this (the build error should be fixed) and hope that it sticks. If the build breaks, back it out, if a lint job breaks and it's not something a sheriff can auto-fix, then back it out also.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/36f5dbe746ec
More Cut over for resistinfingerprinting API: UseStandinsForNativeColors and Appwindow r=tjr

Comment 4

[Natalia Csoregi [:nataliaCs]]

Backed out for bustage on nsContentUtils.cpp

• backout: https://hg.mozilla.org/integration/autoland/rev/799a0280b2137880417e093103f136643506ac60

• push: https://treeherder.mozilla.org/jobs?repo=autoland&revision=36f5dbe746ec1cc2c168ef8f99c6479a658dea55&selectedTaskRun=P2l_tq33SnSyUeWcx_ugOw.0

• failure log: https://treeherder.mozilla.org/logviewer?job_id=360411636&repo=autoland&lineNumber=7850

[task 2021-12-07T17:06:28.904Z] 17:06:28     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ --sysroot /builds/worker/fetches/sysroot-x86_64-linux-gnu -std=gnu++17 -o nsContentUtils.o -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fstack-clash-protection -DNDEBUG=1 -DTRIMMED=1 -DOS_POSIX=1 -DOS_LINUX=1 -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/dom/base -I/builds/worker/workspace/obj-build/dom/base -I/builds/worker/checkouts/gecko/dom/battery -I/builds/worker/checkouts/gecko/dom/events -I/builds/worker/checkouts/gecko/dom/media -I/builds/worker/checkouts/gecko/dom/network -I/builds/worker/checkouts/gecko/caps -I/builds/worker/checkouts/gecko/docshell/base -I/builds/worker/checkouts/gecko/dom/base -I/builds/worker/checkouts/gecko/dom/file -I/builds/worker/checkouts/gecko/dom/geolocation -I/builds/worker/checkouts/gecko/dom/html -I/builds/worker/checkouts/gecko/dom/ipc -I/builds/worker/checkouts/gecko/dom/storage -I/builds/worker/checkouts/gecko/dom/svg -I/builds/worker/checkouts/gecko/dom/u2f -I/builds/worker/checkouts/gecko/dom/xml -I/builds/worker/checkouts/gecko/dom/xslt/xpath -I/builds/worker/checkouts/gecko/dom/xul -I/builds/worker/checkouts/gecko/gfx/2d -I/builds/worker/checkouts/gecko/image -I/builds/worker/checkouts/gecko/js/xpconnect/loader -I/builds/worker/checkouts/gecko/js/xpconnect/src -I/builds/worker/checkouts/gecko/js/xpconnect/wrappers -I/builds/worker/checkouts/gecko/layout/base -I/builds/worker/checkouts/gecko/layout/forms -I/builds/worker/checkouts/gecko/layout/generic -I/builds/worker/checkouts/gecko/layout/style -I/builds/worker/checkouts/gecko/layout/xul -I/builds/worker/checkouts/gecko/netwerk/base -I/builds/worker/checkouts/gecko/netwerk/url-classifier -I/builds/worker/checkouts/gecko/security/manager/ssl -I/builds/worker/checkouts/gecko/widget -I/builds/worker/checkouts/gecko/xpcom/ds -I/builds/worker/checkouts/gecko/netwerk/sctp/datachannel -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -Qunused-arguments -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wdeprecated-this-capture -Wempty-body -Wformat-type-confusion -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wno-error=tautological-type-limit-compare -Wunreachable-code -Wunreachable-code-return -Wunused-but-set-parameter -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wc++2a-compat -Wcomma -Wenum-compare-conditional -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=free-nonheap-object -Wno-error=return-std-move -Wno-error=atomic-alignment -Wno-error=deprecated-copy -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-psabi -Wno-unknown-warning-option -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fcrash-diagnostics-dir=/builds/worker/artifacts -fno-exceptions -fno-strict-aliasing -fPIC -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -fno-omit-frame-pointer -funwind-tables -Werror -I/builds/worker/checkouts/gecko/widget/gtk/compat-gtk3 -pthread -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/gtk-3.0/unix-print -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/gtk-3.0 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/at-spi2-atk/2.0 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/at-spi-2.0 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/dbus-1.0 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/gtk-3.0 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/cairo -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/pango-1.0 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/harfbuzz -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/pango-1.0 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/atk-1.0 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/cairo -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/pixman-1 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/freetype2 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/libpng12 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/gdk-pixbuf-2.0 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/libpng12 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/gio-unix-2.0/ -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/glib-2.0 -I/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/lib/x86_64-linux-gnu/glib-2.0/include -fexperimental-new-pass-manager  -MD -MP -MF .deps/nsContentUtils.o.pp   /builds/worker/checkouts/gecko/dom/base/nsContentUtils.cpp
[task 2021-12-07T17:06:28.904Z] 17:06:28    ERROR -  /builds/worker/checkouts/gecko/dom/base/nsContentUtils.cpp:2307:14: error: ISO C++11 does not allow conversion from string literal to 'char *' [-Werror,-Wwritable-strings]
[task 2021-12-07T17:06:28.904Z] 17:06:28     INFO -               "we want to have consistent colors across the browser if RFP is "
[task 2021-12-07T17:06:28.904Z] 17:06:28     INFO -               ^
[task 2021-12-07T17:06:28.904Z] 17:06:28     INFO -  1 error generated.
[task 2021-12-07T17:06:28.904Z] 17:06:28    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:661: nsContentUtils.o] Error 1
[task 2021-12-07T17:06:28.904Z] 17:06:28     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/dom/base'
[task 2021-12-07T17:06:28.904Z] 17:06:28     INFO -  gmake[4]: *** Waiting for unfinished jobs....
[task 2021-12-07T17:06:28.904Z] 17:06:28     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/dom/bindings'
[task 2021-12-07T17:06:28.905Z] 17:06:28     INFO -  dom/bindings/UnifiedBindings1.o

first seen on: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=LKqWHrevQwuRbzvnQaMjpQ.0&searchStr=linux%2Cx64%2Cwebrender%2Copt%2Cvalgrind-linux64-valgrind-qr%2Fopt-swr%2Cv-swr&revision=0d482ab2edec9912e116431a9abb886ddeff7f21

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/50a2736ff233
More Cut over for resistinfingerprinting API: UseStandinsForNativeColors and Appwindow r=tjr

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/50a2736ff233