Closed Bug 17369 Opened 25 years ago Closed 24 years ago

Tweak PLEvent handling on Mac for responsive UI

Categories

(Core :: Layout, defect, P1)

PowerPC
Mac System 8.5
defect

Tracking

()

VERIFIED DUPLICATE of bug 44678

People

(Reporter: sfraser_bugs, Assigned: dougt)

References

Details

(Keywords: perf, platform-parity)

We need to fix the incremental notification stuff to not suck so much on Mac.
Target Milestone: M12
setting this to M12
Summary: Incremental content appended notifications cause very slow layout on Mac → [Perf][Dogfood] Incremental content appended notifications cause very slow layout on Mac
Making dogfood:

It looks to me like this change is resulting in many more reflows
and repaints, which has really impacted the loading of some pages.
For example, loading the Tinderbox page, and the Mozilla
community page <http://www.mozilla.org/community.html> is very
much slower in a recent build.

In this latter case, the page took around 31 seconds to fully
load in apprunner, and under 4 seconds in 4.5. Also, on Mac,
while the page was loading, the system was entirely unresponsive
to user events.
Whiteboard: [PDT+]
Blocks: 12658
Priority: P3 → P1
Blocks: 17907
Whiteboard: [PDT+] → [PDT+] [by 12/3]
this one has been investigated but, a resolution has not been identified yet,
this may or may not require assistance from nisheeth
Status: NEW → ASSIGNED
Depends on: 17325
Summary: [Perf][Dogfood] Incremental content appended notifications cause very slow layout on Mac → [Perf][Dogfood] Tweak PLEvent handling on Mac for responsive UI
Whiteboard: [PDT+] [by 12/3] → [PDT+] (waiting on 17325)
Adjusting summary to reflect the mac-specific work that needs to be done --
tweaking PLEvent handling on Mac, to ensure that the UI remains responsive.

This is at least partially dependent on the incremental reflow performance bug
17325.
Putting on PDT- radar with sfraser's blessing.
Whiteboard: [PDT+] (waiting on 17325) → [PDT-] (waiting on 17325)
No longer blocks: 12658
removing 12658 dependency since this is now PDT-
Target Milestone: M12 → M14
M14
Keywords: perf
Summary: [Perf][Dogfood] Tweak PLEvent handling on Mac for responsive UI → Dogfood] Tweak PLEvent handling on Mac for responsive UI
Moving "perf" to keyword field.  This is the are we use now :-)
moving out to m16 -- 17325 isn't slotted to be fixed until m15
Target Milestone: M14 → M16
moving from leftover dogfood to beta1 radar, per beta criteria priority #2 - 
performance. Having common project pages take nearly 8 times as long as 4.5 
should qualify.  cc waterson
Keywords: beta1
Summary: Dogfood] Tweak PLEvent handling on Mac for responsive UI → Tweak PLEvent handling on Mac for responsive UI
Whiteboard: [PDT-] (waiting on 17325) → (waiting on 17325)
Very old bug...need to know if this is still a perf issue with latest builds.
The work remains to be done.
How bad is this now.  17325 should enhance this greatly anbd just landed.
Adding [NEED INFO] to Status Summary.
Whiteboard: (waiting on 17325) → [NEED INFO](waiting on 17325)
This is not hard to do, and is something that has been tweaked on the other 
platforms. It's a "suck it and see" type optimization.
Keywords: pp
Simon: If this is your most important perf bug, please fix it for beta. 
Otherwise, we'll take it post-beta. Marking PDT-.
Whiteboard: [NEED INFO](waiting on 17325) → [PDT+][NEED INFO](waiting on 17325)
This is no way my most important bug. The performance improvements that may 
result from this change are unknown; the change is of the 'suck it and see' 
variety.
Whiteboard: [PDT+][NEED INFO](waiting on 17325) → [PDT-]
M15
Target Milestone: M16 → M15
I tried making changes so that the Mac code only handled one PLEvent each time 
through the main event loop (uncomment the MAC_PL_EVENT_TWEAKING #define in 
mozilla/widget/src/mac/nsToolkit.cpp to try this). However, this broke mail: I 
could no longer read IMAP mail with this change.
To be more explicit: mail stalls when loading the first IMAP folder with this 
change. The status string sticks at 'Checking mail server capabilities'.
smfr, I'll try to help take a look at this on my mac tomorrow.
So I lied. I got sucked back into the beta branch today working on some stuff.
'fraid i won't be able to help until tomorrow...
M16
Target Milestone: M15 → M16
Added keyword nsbeta2.
Keywords: nsbeta2
Whiteboard: [PDT-]
M17, perf
Keywords: nsbeta2
Target Milestone: M16 → M17
removing beta keyword, this is perf work
Keywords: beta1
No longer blocks: 17907
dougt should really own this.
Assignee: sfraser → dougt
Status: ASSIGNED → NEW
I did the tweaking.  a fix/patch is in bug 44678.  I have not seeing any 
problems with this patch.  I am going to mark this as a dupe.

*** This bug has been marked as a duplicate of 44678 ***
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → DUPLICATE
verified duplicate
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.