1736939 - Re-add "Search history" item to history (sub) views from history and library buttons

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, enhancement, P5)

Description

[Patrik Krajcovic [:patricek] (she/her)]

Attachment: HistoryMenuAndSidebarFirefox.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:93.0) Gecko/20100101 Firefox/93.0

Steps to reproduce:

1. Add history menu button on toolbar
2. Click to it and it open history menu

Actual results:

Search box in history menu is not

In example: in Microsoft Edge Chromium search box appear when you click to search icon on history flyout

Another example: in Firefox on history sidebar, search box appear

Note: search in history menu in very early versions of Firefox appear but in form of a menu item

Expected results:

Search box in history menu should appear

Comment 1

[Patrik Krajcovic [:patricek] (she/her)]

Attachment: HistoryFlyoutEdge.png

History flyout in edge

Comment 2

[Patrik Krajcovic [:patricek] (she/her)]

i dont know but this should affect Firefox 94 and 95 (i only think, iam have new computer and i have not installed nightly and dev or beta)

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Search' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 4

[Patrik Krajcovic [:patricek] (she/her)]

BugBug bot triaged almost similarly bug named "Add search box in bookmark menu" (reported by me) with different category, iam confused

Comment 5

[Patrik Krajcovic [:patricek] (she/her)]

i think should be both two "Search" Category or both two "Bookmarks & History" category or category "Menus" i dont know

Comment 6

[Alin Ilea, Desktop Test Engineering]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:93.0) Gecko/20100101 Firefox/93.0

Hi,

Thank you for opening this enhancement. I will set this as New and waiting for the developers opinion about it.

Thanks for your report.

Comment 7

[Mark Banner (:standard8)]

We could probably add a new entry to the history button, that takes you to the address bar search focussed on history (similar to the "Search Bookmarks" option in the Library -> Bookmarks menu).

Comment 8

[Marc Seibert (:mseibert)]

Attachment: Bug 1736939 - Re-add "Search history" item to history (sub) views from history and library buttons. r=dao

Comment 9

[Dão Gottwald [:dao]]

Comment on attachment 9328848 [details]
Bug 1736939 - Re-add "Search history" item to history (sub) views from history and library buttons. r=dao

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

1. What questions will you answer with this data?

How the history mode feature in the Urlbar is used, including how users find the feature. This adds telemetry for various history mode entry points: Main menu button > History > Search history; Library button > History > Search history; History button > Search history. The probe doesn't differentiate between the main menu button, the library button, and the history button. See bug 1665076 for when we added telemetry for similar entry points.

2. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?

Without recording telemetry on these entry points, our search mode data will be incomplete. We want to know how search mode is accessed to know what entry points to invest in or remove.

3. What alternative methods did you consider to answer these questions? Why were they not sufficient?

The search mode telemetry is well established at this point, this just makes it cover the history entry points we're adding. I don't know how else we'd approach this.

4. Can current instrumentation answer these questions?

No.

5. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories found on the Mozilla wiki.

urlbar.searchmode.historymenu

Category 2: Adding the urlbar.searchmode.historymenu scalar. The keys for urlbar.searchmode.* scalars are strings describing what kind of search mode was entered, i.e. "history" in this case.

6. Please provide a link to the documentation for this data collection which describes the ultimate data set in a public, complete, and accurate way.

The documentation on Urlbar telemetry will be updated with this patch to describe the new probe.

7. How long will this data be collected?

The search team will permanently monitor this data.

8. What populations will you measure?

All channels, countries, and locales.

9. If this data collection is default on, what is the opt-out mechanism for users?

Standard telemetry opt-out.

10. Please provide a general description of how you will analyze this data.

We will use the measurement dashboard.

11. Where do you intend to share the results of your analysis?

Internally, with the search team and Firefox Desktop leadership.

12. Is there a third-party tool (i.e. not Glean or Telemetry) that you are proposing to use for this data collection? If so:

No.

Comment 10

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Comment on attachment 9328848 [details]
Bug 1736939 - Re-add "Search history" item to history (sub) views from history and library buttons. r=dao

data-review+

---

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, the usual desktop Firefox data docs.

2. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, the usual desktop Firefox telemetry opt out in about:preferences.

3. If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, the search team will monitor via the [e-mail] email alias.

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, interaction data.

5. Is the data collection request for default-on or default-off?

Default on.

6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No.

7. Is the data collection covered by the existing Firefox privacy notice?

Yes.

8. Does the data collection use a third-party collection tool?

No.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/863228beb272
Re-add "Search history" item to history (sub) views from history and library buttons. r=dao,fluent-reviewers,flod

Comment 12

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/863228beb272

Comment 13

[Dão Gottwald [:dao]]

Release Note Request (optional, but appreciated)
[Why is this notable]: This is accompanying bug 1736937 and makes the address bar's "Search history" feature easier to use
[Affects Firefox for Android]: no
[Suggested wording]: Restrict searches to your local browsing history by selecting "Search history" from the History, Library or Application menu buttons.
[Links (documentation, blog post, etc)]:

Comment 14

[Pascal Chevrel (relman team) -> :pascalc]

Note added to Nightly release notes, thanks.

Comment 15

[Patrik Krajcovic [:patricek] (she/her)]

And what about “Search history” in menu bar? Can I file a new issue about it?