Closed Bug 1736937 Opened 2 years ago Closed 11 months ago

Add "Search bookmarks" option in bookmarks menu

Categories

(Firefox :: Bookmarks & History, enhancement, P3)

Firefox 93
enhancement

Tracking

()

RESOLVED FIXED
114 Branch
Tracking Status
relnote-firefox --- 114+
firefox114 --- fixed

People

(Reporter: patricek, Assigned: mseibert, Mentored)

References

(Depends on 1 open bug)

Details

Attachments

(4 files)

Attached image BookmarkMenuFirefox.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:93.0) Gecko/20100101 Firefox/93.0

Steps to reproduce:

  1. Add bookmarks menu button on toolbar
  2. Click to it and it open bookmark menu

Actual results:

Search box in bookmarks menu is not

In example: in Microsoft Edge Chromium search box appear when you click to search icon on bookmarks flyout

Another example: in Firefox on bookmarks sidebar, search box appear

Expected results:

Search box in bookmarks menu should appear

Attached image BookmarksFlyoutEdge.png

In edge bookmarks flyout

In firefox bookmarks sidebar search box here is

The Bugbug bot thinks this bug should belong to the 'Firefox::Bookmarks & History' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Component: Untriaged → Bookmarks & History

Hi PatrikKrajcovic2,

This could be an enhancement, so I´ll tag this as "New" for visibility.

Thanks for your report,

Estanislao

Status: UNCONFIRMED → NEW
Ever confirmed: true

We could add the "Search bookmarks" option from the Library button -> Bookmarks option to the bookmarks button.

Severity: -- → N/A
Priority: -- → P3
Assignee: nobody → mseibert
Mentor: dao+bmo
Status: NEW → ASSIGNED
Summary: Add search box in bookmark menu → Add "Search bookmarks" option in bookmarks menu
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/48c487e6d15e
Add "Search bookmarks" option in bookmarks menu. r=dao
See Also: → 1736939

Nice work, guys. By the way, I also reported downloads search box feature request (here: https://bugzilla.mozilla.org/show_bug.cgi?id=1736988).

Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → 114 Branch

:mseibert could you please consider nominating this for a relnote? https://wiki.mozilla.org/Release_Management/Release_Notes#Nomination_in_Bugzilla

Flags: needinfo?(mseibert)

Release Note Request (optional, but appreciated)

[Why is this notable]: It homogenizes the functionality of the "Hamburger/Bookmarks"-panel and the bookmarks-menu-button-popup. Both support searching bookmarks from the urlbar, now.
[Affects Firefox for Android]: no
[Suggested wording]: Bookmarks can now be searched from the bookmarks menu. The bookmarks menu is accessible by adding the "Bookmarks menu" button to the toolbar.
[Links (documentation, blog post, etc)]:

Flags: needinfo?(mseibert)
relnote-firefox: --- → ?

Note added to Nightly 114 release notes in the NEW section with this wording:

Bookmarks can now be searched from the Bookmarks menu. The Bookmarks menu is accessible by adding the Bookmarks menu button to the toolbar.

Leaving the relnote-firefox flag as ? until this is added to the final 114 relnotes

It was pointed out to me in another forum that with the Menu Bar enabled if click on the 'Bookmarks' there is NO search item in that menu.
Should there be ?

(In reply to Jim Jeffery not reading bug-mail 1/2/11 from comment #13)

It was pointed out to me in another forum that with the Menu Bar enabled if click on the 'Bookmarks' there is NO search item in that menu.
Should there be ?

Sounds like a good idea. Would you mind filing a new bug on this?

Depends on: 1842191
Blocks: 1843875
You need to log in before you can comment on or make changes to this bug.