1737043 - On "site not found" pages for "foo", put a suggestion for "www.foo.com" if it exists

Status: VERIFIED FIXED

(Firefox :: Security, enhancement)

Description

[:Gijs (out for now; he/him)]

See bug 1679556 comment 17 for context.

Comment 1

[:Gijs (out for now; he/him)]

Attachment: Bug 1737043 - add a suggestion for 'example.com' in the network error page for 'example', r?mak!

Comment 2

[James Teow [:jteow]]

Attachment: WIP: - Bug 1737043 - Toggle browser.fixup.alternate.enabled and add telemetry, r?mak

The suggested solution for this bug is to disable browser.fixup.alternate.enabled
unless toggled by the user, and to add telemetry to the preference so that if we
find users rarely use the option, we can safely remove the feature in a future release.

Edit: Please disregard this comment, this was for a different bug.

Comment 3

[Phabricator Automation]

Comment on attachment 9278994 [details]
WIP: - Bug 1737043 - Toggle browser.fixup.alternate.enabled and add telemetry, r?mak

Revision D147795 was moved to bug 1679556. Setting attachment 9278994 [details] to obsolete.

Comment 4

[:Gijs (out for now; he/him)]

James is looking at this! 🎉

Comment 5

[Francesco Lodolo [:flod]]

Can someone point me to the source of content updates?

Comment 6

[James Teow [:jteow]]

Hi :flod, I made the changes based on the designs in the following Figma File: https://www.figma.com/file/tcLAFl4pzPbXDvEUzfVTaP/Disable-alternate-fixup-in-the-Address-Bar?node-id=2%3A83

Comment 7

[Francesco Lodolo [:flod]]

(In reply to James Teow [:jteow] from comment #6)

Hi :flod, I made the changes based on the designs in the following Figma File: https://www.figma.com/file/tcLAFl4pzPbXDvEUzfVTaP/Disable-alternate-fixup-in-the-Address-Bar?node-id=2%3A83

Thanks, I wanted do double check the lack of periods in each bullet list item. That's one more reason why we can't migrate those strings from DTD, and they will need to be translated from scratch in the FTL file.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/89d291a9ee9b
add a suggestion for 'example.com' in the network error page for 'example', r=mak,eemeli,desktop-theme-reviewers,dao

Comment 9

[Iulian Moraru]

Backed out for causing xpcshell failures on test_URIFixup_check_host.js.

Push with failures

Failure log

Backout link

[task 2022-07-17T17:30:10.287Z] 17:30:10     INFO -  TEST-START | docshell/test/unit/test_URIFixup_check_host.js
[task 2022-07-17T17:30:10.475Z] 17:30:10  WARNING -  TEST-UNEXPECTED-FAIL | docshell/test/unit/test_URIFixup_check_host.js | xpcshell return code: 0
[task 2022-07-17T17:30:10.476Z] 17:30:10     INFO -  TEST-INFO took 187ms
[task 2022-07-17T17:30:10.477Z] 17:30:10     INFO -  >>>>>>>
[task 2022-07-17T17:30:10.479Z] 17:30:10     INFO -  PID 28156 | [Parent 28156, Main Thread] WARNING: Couldn't get the user appdata directory. Crash events may not be produced.: file /builds/worker/checkouts/gecko/toolkit/crashreporter/nsExceptionHandler.cpp:2964
[task 2022-07-17T17:30:10.479Z] 17:30:10     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2022-07-17T17:30:10.480Z] 17:30:10     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2022-07-17T17:30:10.481Z] 17:30:10     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2022-07-17T17:30:10.481Z] 17:30:10     INFO -  running event loop
[task 2022-07-17T17:30:10.482Z] 17:30:10     INFO -  PID 28156 | Couldn't convert chrome URL: chrome://branding/locale/brand.properties
[task 2022-07-17T17:30:10.483Z] 17:30:10     INFO -  PID 28156 | [Parent 28156, Main Thread] WARNING: Could not get the program name for a cubeb stream.: 'NS_SUCCEEDED(rv)', file /builds/worker/checkouts/gecko/dom/media/CubebUtils.cpp:427
[task 2022-07-17T17:30:10.488Z] 17:30:10     INFO -  docshell/test/unit/test_URIFixup_check_host.js | Starting setup
[task 2022-07-17T17:30:10.489Z] 17:30:10     INFO -  (xpcshell/head.js) | test setup pending (2)
[task 2022-07-17T17:30:10.489Z] 17:30:10     INFO -  (xpcshell/head.js) | test run_next_test 0 finished (2)
[task 2022-07-17T17:30:10.490Z] 17:30:10     INFO -  (xpcshell/head.js) | test run_next_test 1 pending (2)
[task 2022-07-17T17:30:10.491Z] 17:30:10     INFO -  (xpcshell/head.js) | test setup finished (2)
[task 2022-07-17T17:30:10.493Z] 17:30:10     INFO -  "CONSOLE_MESSAGE: (info) No chrome package registered for chrome://branding/locale/brand.properties"
[task 2022-07-17T17:30:10.494Z] 17:30:10     INFO -  docshell/test/unit/test_URIFixup_check_host.js | Starting test_uri_with_force_fixup
[task 2022-07-17T17:30:10.495Z] 17:30:10     INFO -  (xpcshell/head.js) | test test_uri_with_force_fixup pending (2)
[task 2022-07-17T17:30:10.496Z] 17:30:10     INFO -  PID 28156 | JavaScript error: resource://gre/modules/XPCOMUtils.sys.mjs, line 299: Error: Default value does not match preference type (Got 32, expected 128) for browser.urlbar.dnsResolveFullyQualifiedNames
[task 2022-07-17T17:30:10.496Z] 17:30:10     INFO -  (xpcshell/head.js) | test run_next_test 1 finished (2)
[task 2022-07-17T17:30:10.497Z] 17:30:10     INFO -  Unexpected exception NS_ERROR_FAILURE:
[task 2022-07-17T17:30:10.497Z] 17:30:10     INFO -  test_uri_with_force_fixup@/builds/worker/workspace/build/tests/xpcshell/tests/docshell/test/unit/test_URIFixup_check_host.js:86:22
[task 2022-07-17T17:30:10.498Z] 17:30:10     INFO -  _run_next_test/<@/builds/worker/workspace/build/tests/xpcshell/head.js:1764:22
[task 2022-07-17T17:30:10.498Z] 17:30:10     INFO -  _run_next_test@/builds/worker/workspace/build/tests/xpcshell/head.js:1764:38
[task 2022-07-17T17:30:10.499Z] 17:30:10     INFO -  run@/builds/worker/workspace/build/tests/xpcshell/head.js:810:9
[task 2022-07-17T17:30:10.499Z] 17:30:10     INFO -  _do_main@/builds/worker/workspace/build/tests/xpcshell/head.js:238:6
[task 2022-07-17T17:30:10.500Z] 17:30:10     INFO -  _execute_test@/builds/worker/workspace/build/tests/xpcshell/head.js:595:5
[task 2022-07-17T17:30:10.501Z] 17:30:10     INFO -  @-e:1:1
[task 2022-07-17T17:30:10.501Z] 17:30:10     INFO -  exiting test
[task 2022-07-17T17:30:10.502Z] 17:30:10     INFO -  "CONSOLE_MESSAGE: (error) [JavaScript Error: "Error: Default value does not match preference type (Got 32, expected 128) for browser.urlbar.dnsResolveFullyQualifiedNames" {file: "resource://gre/modules/XPCOMUtils.sys.mjs" line: 299}]
[task 2022-07-17T17:30:10.503Z] 17:30:10     INFO -  XPCU_defineLazyPreferenceGetter@resource://gre/modules/XPCOMUtils.sys.mjs:299:17
[task 2022-07-17T17:30:10.503Z] 17:30:10     INFO -  @resource://gre/modules/URIFixup.jsm:89:12
[task 2022-07-17T17:30:10.504Z] 17:30:10     INFO -  test_uri_with_force_fixup@/builds/worker/workspace/build/tests/xpcshell/tests/docshell/test/unit/test_URIFixup_check_host.js:86:22
[task 2022-07-17T17:30:10.505Z] 17:30:10     INFO -  _run_next_test/<@/builds/worker/workspace/build/tests/xpcshell/head.js:1764:22
[task 2022-07-17T17:30:10.506Z] 17:30:10     INFO -  _run_next_test@/builds/worker/workspace/build/tests/xpcshell/head.js:1764:38
[task 2022-07-17T17:30:10.507Z] 17:30:10     INFO -  run@/builds/worker/workspace/build/tests/xpcshell/head.js:810:9
[task 2022-07-17T17:30:10.508Z] 17:30:10     INFO -  _do_main@/builds/worker/workspace/build/tests/xpcshell/head.js:238:6
[task 2022-07-17T17:30:10.508Z] 17:30:10     INFO -  _execute_test@/builds/worker/workspace/build/tests/xpcshell/head.js:595:5
[task 2022-07-17T17:30:10.508Z] 17:30:10     INFO -  @-e:1:1
[task 2022-07-17T17:30:10.508Z] 17:30:10     INFO -  "
[task 2022-07-17T17:30:10.508Z] 17:30:10     INFO -  PID 28156 | [Parent 28156, Main Thread] WARNING: Extra shutdown CC: 'i < NORMAL_SHUTDOWN_COLLECTIONS', file /builds/worker/checkouts/gecko/xpcom/base/nsCycleCollector.cpp:3359
[task 2022-07-17T17:30:10.508Z] 17:30:10     INFO -  PID 28156 | [Parent 28156, Main Thread] WARNING: OOPDeinit() without successful OOPInit(): file /builds/worker/checkouts/gecko/toolkit/crashreporter/nsExceptionHandler.cpp:3420
[task 2022-07-17T17:30:10.508Z] 17:30:10     INFO -  PID 28156 | [Parent 28156, Main Thread] WARNING: NS_ENSURE_TRUE(Preferences::InitStaticMembers()) failed: file /builds/worker/checkouts/gecko/modules/libpref/Preferences.cpp:4595
[task 2022-07-17T17:30:10.509Z] 17:30:10     INFO -  PID 28156 | [Parent 28156, Main Thread] WARNING: XPCOM object PerThreadData destroyed from static ctor/dtor: file /builds/worker/checkouts/gecko/xpcom/base/nsTraceRefcnt.cpp:206
[task 2022-07-17T17:30:10.510Z] 17:30:10     INFO -  PID 28156 | [Parent 28156, Main Thread] WARNING: XPCOM object SourceList destroyed from static ctor/dtor: file /builds/worker/checkouts/gecko/xpcom/base/nsTraceRefcnt.cpp:206
[task 2022-07-17T17:30:10.510Z] 17:30:10     INFO -  <<<<<<<
[task 2022-07-17T17:30:10.510Z] 17:30:10     INFO -  INFO | Result summary:
[task 2022-07-17T17:30:10.511Z] 17:30:10     INFO -  INFO | Passed: 771
[task 2022-07-17T17:30:10.511Z] 17:30:10  WARNING -  INFO | Failed: 1
[task 2022-07-17T17:30:10.512Z] 17:30:10  WARNING -  One or more unittests failed.
[task 2022-07-17T17:30:10.512Z] 17:30:10     INFO -  INFO | Todo: 0
[task 2022-07-17T17:30:10.513Z] 17:30:10     INFO -  INFO | Retried: 1
[task 2022-07-17T17:30:10.513Z] 17:30:10     INFO -  SUITE-END | took 660s
[task 2022-07-17T17:30:10.514Z] 17:30:10     INFO -  Node moz-http2 server shutting down ...
[task 2022-07-17T17:30:10.514Z] 17:30:10     INFO -  http3Server server shutting down ...
[task 2022-07-17T17:30:10.555Z] 17:30:10    ERROR - Return code: 1
[task 2022-07-17T17:30:10.555Z] 17:30:10     INFO - TinderboxPrint: xpcshell-xpcshell<br/>771/<em class="testfail">1</em>/0
[task 2022-07-17T17:30:10.556Z] 17:30:10  WARNING - # TBPL FAILURE #
[task 2022-07-17T17:30:10.556Z] 17:30:10  WARNING - setting return code to 2
[task 2022-07-17T17:30:10.556Z] 17:30:10  WARNING - The xpcshell suite: xpcshell ran with return status: FAILURE

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c6cafb2781ca
add a suggestion for 'example.com' in the network error page for 'example', r=mak,eemeli,desktop-theme-reviewers,dao

Comment 11

[James Teow [:jteow]]

I'm fairly certain this is because I put the wrong default value for "browser.urlbar.dnsResolveFullyQualifiedNames" so I changed "true" to true, re-tested on Try and found the debug tests were no longer showing those errors. Thus, I'm going to try landing the patch again.

Comment 12

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/c6cafb2781ca

Comment 13

[Cristian Baica [:cbaica], Release Desktop QA]

Marking the issue as verified fixed as part of the sign off for 'Stopping URL manipulations'.