1780413 - A phrase in the connection error page is not bolded as per documentation specs

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P4)

Description

[Cristian Baica [:cbaica], Release Desktop QA]

Attachment: bolded phrase bug

Found in

• Fx104.0a1

Affected versions

• Fx104.0a1

Affected platforms

• Windows 10

Steps to reproduce

1. Launch Firefox.
2. Navigate to http://cnn .
3. Inspect the error page.

Expected result

• The phrase "If you entered the right address, you can:" is bolded.

Actual result

• The phrase is not bolded.

Regression range

• Not a regression.

Additional notes

• The issue does not occur on Ubuntu 20.04 or macOS.
• Please note that in figma documentation the phrase appears bolded and the difference between OSs is not mentioned.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1737043

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:jteow, since you are the author of the regressor, bug 1737043, could you take a look?
For more information, please visit auto_nag documentation.

Comment 3

[James Teow [:jteow]]

Thanks for flagging Cristian. I choose font-weight: 500 because it looked more visually similar to how it looks in the Figma document than 600, but 600 should fix the issue in Windows. So I'll submit a patch that changes thefont-weight to 600.

Comment 4

[James Teow [:jteow]]

Attachment: Bug 1780413 - Make text above bullets bolder on aboutNetError - r=dao

Initially, I made the font-weight 500 in order to mimic the appearance
of the Figma design which used 600 but visually didn't look as bold on the screen
as compared to how it looked in the browser.

But on Windows it doesn't result in the font looking bolder, so it's probably best
to use 600 even if might look slightly more bold on OSX/Linux than the Figma file.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1737043

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b7106dc9078a
Make text above bullets bolder on aboutNetError - r=dao

Comment 7

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/b7106dc9078a

Comment 8

[Dianna Smith [:diannaS]]

:jteow Tomorrow's beta is the last build of early beta. Do you think this something you will want to uplift to 104?

Comment 9

[James Teow [:jteow]]

Hi :diannaS, I don't think I'm going to request an uplift. It's a subtle change and on a page that the vast majority of users shouldn't see on a day to day basis.