Closed Bug 1737197 Opened 3 years ago Closed 3 years ago

[rust 1.56] trailing semicolon in macro used in expression position

Categories

(Toolkit :: Application Update, defect)

Product:
Toolkit
Component:
Application Update
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
95 Branch
Tracking Flags:
Tracking Status
firefox95 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

Bug 1737197 - Remove semicolon in rust macro.
48 bytes, text/x-phabricator-request
Details | Review 
[task 2021-10-21T22:25:44.213Z] 22:25:44     INFO -  error: trailing semicolon in macro used in expression position
[task 2021-10-21T22:25:44.213Z] 22:25:44     INFO -     --> toolkit\components\bitsdownload\bits_client\examples\test_client.rs:41:66
[task 2021-10-21T22:25:44.213Z] 22:25:44     INFO -      |
[task 2021-10-21T22:25:44.213Z] 22:25:44     INFO -  41  |         return Err($crate::MyError::Msg(format!($fmt, $($arg)*)));
[task 2021-10-21T22:25:44.213Z] 22:25:44     INFO -      |                                                                  ^
[task 2021-10-21T22:25:44.213Z] 22:25:44     INFO -  ...
[task 2021-10-21T22:25:44.214Z] 22:25:44     INFO -  161 |             bail!("error from server {}", e)
[task 2021-10-21T22:25:44.214Z] 22:25:44     INFO -      |             -------------------------------- in this macro invocation
[task 2021-10-21T22:25:44.214Z] 22:25:44     INFO -      |
[task 2021-10-21T22:25:44.214Z] 22:25:44     INFO -      = note: `-D semicolon-in-expressions-from-macros` implied by `-D warnings`
[task 2021-10-21T22:25:44.214Z] 22:25:44     INFO -      = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
[task 2021-10-21T22:25:44.214Z] 22:25:44     INFO -      = note: for more information, see issue #79813 <https://github.com/rust-lang/rust/issues/79813>
[task 2021-10-21T22:25:44.215Z] 22:25:44     INFO -      = note: macro invocations at the end of a block are treated as expressions
[task 2021-10-21T22:25:44.215Z] 22:25:44     INFO -      = note: to ignore the value produced by the macro, add a semicolon after the invocation of `bail`
[task 2021-10-21T22:25:44.215Z] 22:25:44     INFO -      = note: this error originates in the macro `bail` (in Nightly builds, run with -Z macro-backtrace for more info)
[task 2021-10-21T22:25:44.215Z] 22:25:44     INFO -  error: trailing semicolon in macro used in expression position
[task 2021-10-21T22:25:44.215Z] 22:25:44     INFO -     --> toolkit\components\bitsdownload\bits_client\examples\test_client.rs:41:66
[task 2021-10-21T22:25:44.216Z] 22:25:44     INFO -      |
[task 2021-10-21T22:25:44.216Z] 22:25:44     INFO -  41  |         return Err($crate::MyError::Msg(format!($fmt, $($arg)*)));
[task 2021-10-21T22:25:44.216Z] 22:25:44     INFO -      |                                                                  ^
[task 2021-10-21T22:25:44.216Z] 22:25:44     INFO -  ...
[task 2021-10-21T22:25:44.216Z] 22:25:44     INFO -  175 |         Err(e) => bail!("error from server {}", e),
[task 2021-10-21T22:25:44.216Z] 22:25:44     INFO -      |                   -------------------------------- in this macro invocation
[task 2021-10-21T22:25:44.216Z] 22:25:44     INFO -      |
[task 2021-10-21T22:25:44.217Z] 22:25:44     INFO -      = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
[task 2021-10-21T22:25:44.217Z] 22:25:44     INFO -      = note: for more information, see issue #79813 <https://github.com/rust-lang/rust/issues/79813>
[task 2021-10-21T22:25:44.217Z] 22:25:44     INFO -      = note: this error originates in the macro `bail` (in Nightly builds, run with -Z macro-backtrace for more info)
[task 2021-10-21T22:25:44.217Z] 22:25:44     INFO -  error: trailing semicolon in macro used in expression position
[task 2021-10-21T22:25:44.217Z] 22:25:44     INFO -     --> toolkit\components\bitsdownload\bits_client\examples\test_client.rs:41:66
[task 2021-10-21T22:25:44.217Z] 22:25:44     INFO -      |
[task 2021-10-21T22:25:44.218Z] 22:25:44     INFO -  41  |         return Err($crate::MyError::Msg(format!($fmt, $($arg)*)));
[task 2021-10-21T22:25:44.218Z] 22:25:44     INFO -      |                                                                  ^
[task 2021-10-21T22:25:44.218Z] 22:25:44     INFO -  ...
[task 2021-10-21T22:25:44.218Z] 22:25:44     INFO -  251 |         Err(e) => bail!("error from server {}", e),
[task 2021-10-21T22:25:44.218Z] 22:25:44     INFO -      |                   -------------------------------- in this macro invocation
[task 2021-10-21T22:25:44.218Z] 22:25:44     INFO -      |
[task 2021-10-21T22:25:44.219Z] 22:25:44     INFO -      = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
[task 2021-10-21T22:25:44.219Z] 22:25:44     INFO -      = note: for more information, see issue #79813 <https://github.com/rust-lang/rust/issues/79813>
[task 2021-10-21T22:25:44.219Z] 22:25:44     INFO -      = note: this error originates in the macro `bail` (in Nightly builds, run with -Z macro-backtrace for more info)
[task 2021-10-21T22:25:44.219Z] 22:25:44     INFO -  error: trailing semicolon in macro used in expression position
[task 2021-10-21T22:25:44.219Z] 22:25:44     INFO -     --> toolkit\components\bitsdownload\bits_client\examples\test_client.rs:41:66
[task 2021-10-21T22:25:44.219Z] 22:25:44     INFO -      |
[task 2021-10-21T22:25:44.220Z] 22:25:44     INFO -  41  |         return Err($crate::MyError::Msg(format!($fmt, $($arg)*)));
[task 2021-10-21T22:25:44.220Z] 22:25:44     INFO -      |                                                                  ^
[task 2021-10-21T22:25:44.220Z] 22:25:44     INFO -  ...
[task 2021-10-21T22:25:44.220Z] 22:25:44     INFO -  259 |         Err(e) => bail!("error from server {}", e),
[task 2021-10-21T22:25:44.220Z] 22:25:44     INFO -      |                   -------------------------------- in this macro invocation
[task 2021-10-21T22:25:44.220Z] 22:25:44     INFO -      |
[task 2021-10-21T22:25:44.220Z] 22:25:44     INFO -      = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
[task 2021-10-21T22:25:44.221Z] 22:25:44     INFO -      = note: for more information, see issue #79813 <https://github.com/rust-lang/rust/issues/79813>
[task 2021-10-21T22:25:44.221Z] 22:25:44     INFO -      = note: this error originates in the macro `bail` (in Nightly builds, run with -Z macro-backtrace for more info)
[task 2021-10-21T22:25:44.221Z] 22:25:44     INFO -  error: trailing semicolon in macro used in expression position
[task 2021-10-21T22:25:44.221Z] 22:25:44     INFO -     --> toolkit\components\bitsdownload\bits_client\examples\test_client.rs:41:66
[task 2021-10-21T22:25:44.221Z] 22:25:44     INFO -      |
[task 2021-10-21T22:25:44.221Z] 22:25:44     INFO -  41  |         return Err($crate::MyError::Msg(format!($fmt, $($arg)*)));
[task 2021-10-21T22:25:44.222Z] 22:25:44     INFO -      |                                                                  ^
[task 2021-10-21T22:25:44.222Z] 22:25:44     INFO -  ...
[task 2021-10-21T22:25:44.222Z] 22:25:44     INFO -  267 |         Err(e) => bail!("error from server {}", e),
[task 2021-10-21T22:25:44.222Z] 22:25:44     INFO -      |                   -------------------------------- in this macro invocation
[task 2021-10-21T22:25:44.222Z] 22:25:44     INFO -      |
[task 2021-10-21T22:25:44.222Z] 22:25:44     INFO -      = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
[task 2021-10-21T22:25:44.222Z] 22:25:44     INFO -      = note: for more information, see issue #79813 <https://github.com/rust-lang/rust/issues/79813>
[task 2021-10-21T22:25:44.223Z] 22:25:44     INFO -      = note: this error originates in the macro `bail` (in Nightly builds, run with -Z macro-backtrace for more info)
[task 2021-10-21T22:25:44.223Z] 22:25:44     INFO -  error: trailing semicolon in macro used in expression position
[task 2021-10-21T22:25:44.223Z] 22:25:44     INFO -     --> toolkit\components\bitsdownload\bits_client\examples\test_client.rs:41:66
[task 2021-10-21T22:25:44.223Z] 22:25:44     INFO -      |
[task 2021-10-21T22:25:44.223Z] 22:25:44     INFO -  41  |         return Err($crate::MyError::Msg(format!($fmt, $($arg)*)));
[task 2021-10-21T22:25:44.223Z] 22:25:44     INFO -      |                                                                  ^
[task 2021-10-21T22:25:44.223Z] 22:25:44     INFO -  ...
[task 2021-10-21T22:25:44.224Z] 22:25:44     INFO -  275 |         Err(e) => bail!("error from server {}", e),
[task 2021-10-21T22:25:44.224Z] 22:25:44     INFO -      |                   -------------------------------- in this macro invocation
[task 2021-10-21T22:25:44.224Z] 22:25:44     INFO -      |
[task 2021-10-21T22:25:44.224Z] 22:25:44     INFO -      = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
[task 2021-10-21T22:25:44.224Z] 22:25:44     INFO -      = note: for more information, see issue #79813 <https://github.com/rust-lang/rust/issues/79813>
[task 2021-10-21T22:25:44.224Z] 22:25:44     INFO -      = note: this error originates in the macro `bail` (in Nightly builds, run with -Z macro-backtrace for more info)
[task 2021-10-21T22:25:44.225Z] 22:25:44     INFO -  error: trailing semicolon in macro used in expression position
[task 2021-10-21T22:25:44.225Z] 22:25:44     INFO -     --> toolkit\components\bitsdownload\bits_client\examples\test_client.rs:41:66
[task 2021-10-21T22:25:44.225Z] 22:25:44     INFO -      |
[task 2021-10-21T22:25:44.225Z] 22:25:44     INFO -  41  |         return Err($crate::MyError::Msg(format!($fmt, $($arg)*)));
[task 2021-10-21T22:25:44.225Z] 22:25:44     INFO -      |                                                                  ^
[task 2021-10-21T22:25:44.225Z] 22:25:44     INFO -  ...
[task 2021-10-21T22:25:44.226Z] 22:25:44     INFO -  283 |         Err(e) => bail!("error from server {}", e),
[task 2021-10-21T22:25:44.226Z] 22:25:44     INFO -      |                   -------------------------------- in this macro invocation
[task 2021-10-21T22:25:44.226Z] 22:25:44     INFO -      |
[task 2021-10-21T22:25:44.226Z] 22:25:44     INFO -      = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
[task 2021-10-21T22:25:44.226Z] 22:25:44     INFO -      = note: for more information, see issue #79813 <https://github.com/rust-lang/rust/issues/79813>
[task 2021-10-21T22:25:44.226Z] 22:25:44     INFO -      = note: this error originates in the macro `bail` (in Nightly builds, run with -Z macro-backtrace for more info)
[task 2021-10-21T22:25:44.227Z] 22:25:44     INFO -  error: could not compile `bits_client` due to 7 previous errors
Blocks: 1736459
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/b24024cac2d4
Remove semicolon in rust macro. r=bytesized

https://hg.mozilla.org/mozilla-central/rev/b24024cac2d4

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox95: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: