1737868 - "Save To Pocket" panel is empty when launched from overflow menu

Status: VERIFIED FIXED

(Firefox :: Pocket, defect, P1)

Description

[Gian-Carlo Pascutto [:gcp]]

The "Save To Pocket" button sits in an overflow panel in the main toolbar. It is now completely empty for me on a M1 Macbook Air.

This does not reproduce on a clean profile.

Bisecting gets to the following range, at which point all builds start crashing on startup:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c11d60ea8989f78f258f4e30a968a779af737436&tochange=06d659a9bb93bf87ed51070d6a861e6e60bff6d7

This contains: https://bugzilla.mozilla.org/show_bug.cgi?id=1693582

Which seems highly relevant.

Comment 1

[Gian-Carlo Pascutto [:gcp]]

It is now completely empty for me on a M1 Macbook Air.

To clarify: the button folds open a panel, but the contents is empty, i.e. it's a big rectangular white square.

Comment 2

[:Gijs (he/him)]

Do any errors show up in the browser console when this fails?

Comment 3

[Gian-Carlo Pascutto [:gcp]]

browser.ui.interaction.pinned_overflow-menu - Unknown scalar.
debuggee 'resource://devtools/shared/base-loader.js:289' would run 2 builtin-modules.js:202:11
debuggee 'resource://devtools/shared/base-loader.js:289' would run 2 builtin-modules.js:202:11
debuggee 'resource://devtools/shared/base-loader.js:289' would run 2 builtin-modules.js:202:11

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1693582

Comment 5

[:Gijs (he/him)]

(In reply to Gian-Carlo Pascutto [:gcp] from comment #0)

This does not reproduce on a clean profile.

Hm, with no relevant errors and not being able to repro on a clean profile, it's a bit tricky to see what's going on here... Does it repro on a clean profile if you copy your prefs.js file over? And/or after you do the initial log in to pocket? (I'm assuming you've got it in the overflow panel in the otherwise clean profile as well, if not then that might also make a difference here)

Comment 6

[:Gijs (he/him)]

(My suspicion is that this has to do with some kind of pref - related to graphics, cookies, sandboxing or processes/fission, but of course at this point that's just speculation...)

Comment 7

[Gian-Carlo Pascutto [:gcp]]

It's reproducible in an empty profile if I move the Save To Pocket button to the overflow menu, instead of the main toolbar.

Comment 8

[Gian-Carlo Pascutto [:gcp]]

Not sure if relevant:

UNSUPPORTED (log once): POSSIBLE ISSUE: unit 1 GLD_TEXTURE_INDEX_2D is unloadable and bound to sampler type (Float) - using zero texture because texture unloadable

(this appears in a debug build)

Comment 9

[Gavin Suntop [:gvn] (they/them)]

FWIW I was not able to repro this on a MacBook Pro (13-inch, M1, 2020)

Comment 10

[:Gijs (he/him)]

Attachment: Screencast

(In reply to Gavin Suntop [:gvn] (they/them) from comment #9)

FWIW I was not able to repro this on a MacBook Pro (13-inch, M1, 2020)

Odd, I can reproduce easily on my mac (intel, but that shouldn't matter). I've attached a screencast. The steps are basically:

1. clean profile on nightly
2. open browser
3. switch to the tab that has an https URL if needed
4. right click pocket
5. pin to overflow menu
6. open overflow menu
7. open pocket

Does that help?

Comment 12

[Scott [:thecount] Downe]

I think I have a fix for this.

Comment 13

[Gavin Suntop [:gvn] (they/them)]

Thanks Gijs...I wasn't seeing it earlier but I do now on 96.0a1 (2021-11-08) (64-bit) (MacBook Pro (13-inch, M1, 2020))

Comment 14

[Scott [:thecount] Downe]

Attachment: Bug 1737868 - Pocket panel overflow menu not properly getting the remote attribute.

Comment 15

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:thecount, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 16

[Scott [:thecount] Downe]

[Tracking Requested - why for this release]: Going to try for uplift on this.

Landing it in nightly right now, then probably tomorrow assuming that goes good I'll be looking to request uplift for this one.

It's just a few lines being moved from 1 spot to another, and a test, should be low risk.

This is causing user issues on mac where the pocket panel is empty if it's opened from the overflow menu.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/57e25eb98e8a
Pocket panel overflow menu not properly getting the remote attribute. r=mconley

Comment 18

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/57e25eb98e8a

Comment 19

[Scott [:thecount] Downe]

Comment on attachment 9250029 [details]
Bug 1737868 - Pocket panel overflow menu not properly getting the remote attribute.

Beta/Release Uplift Approval Request

• User impact if declined: User experience issue with broken Pocket panel in some cases.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Prerequisite: mac os only

1. Right click the Pocket button and click pin to overflow menu.
2. Open the Pocket panel from the button in the overflow menu.

Expected: Should see a complete Pocket panel for both signup and saved.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Pretty low, just moving some code.
• String changes made/needed: None

Comment 20

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (96.0a1 Build ID - 20211118034937) installed on macOS 11.6. Now, I can confirm that the elements from the "Save to Pocket" doorhanger are successfully displayed if the "Save to Pocket" toolbar button is pinned to the "Overflow Menu".

Comment 21

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9250029 [details]
Bug 1737868 - Pocket panel overflow menu not properly getting the remote attribute.

Approved for 95 beta 9, thanks.

Comment 22

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/1a7eea930e84

Comment 23

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Beta (95.0b9 Build ID - 20211118185700) installed on macOS 11.6. Now, I can confirm that the elements from the "Save to Pocket" doorhanger are successfully displayed if the "Save to Pocket" toolbar button is pinned to the "Overflow Menu".