1738021 - Potentially misspelled Telemetry Scalars

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect, P3)

Description

[Gian-Carlo Pascutto [:gcp]]

+++ This bug was initially created as a clone of Bug #1675892 +++

See: https://bugzilla.mozilla.org/show_bug.cgi?id=1737868#c3 specifically browser.ui.interaction.pinned_overflow-menu - Unknown scalar.

Googling the error brings a bunch of identical hits. Looking into Scalars.yaml, it looks like pinned_overflow_menu is misspelled or being misrecorded.

Comment 1

[Gian-Carlo Pascutto [:gcp]]

Ok I think I see the bug: https://searchfox.org/mozilla-central/rev/f8576fec48d866c5f988baaf1fa8d2f8cce2a82f/browser/modules/BrowserUsageTelemetry.jsm#825

I'll prepare a patch.

Comment 2

[Gian-Carlo Pascutto [:gcp]]

Attachment: Bug 1738021 - Make sure to replace all dashes for Telemetry probes. r?gijs

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff38beee092b
Make sure to replace all dashes for Telemetry probes. r=Gijs

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/ff38beee092b

Comment 5

[Andra Esanu (needinfo me)]

== Change summary for alert #32205 (as of Mon, 01 Nov 2021 09:36:53 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
10%	perf_reftest_singletons window-named-property-get.html	macosx1015-64-shippable-qr	e10s stylo webrender	723.69 -> 649.57

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=32205

Comment 6

[:Gijs (he/him)]

(In reply to Andra Esanu from comment #5)

== Change summary for alert #32205 (as of Mon, 01 Nov 2021 09:36:53 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
10%	perf_reftest_singletons window-named-property-get.html	macosx1015-64-shippable-qr	e10s stylo webrender	723.69 -> 649.57

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=32205

I suspect this is getting misattributed - I don't see how a change in browser chrome would have influenced perf-reftests which check stuff relating to webpage rendering.

Comment 7

[Andra Esanu (needinfo me)]

Thank you for the answer. It seems to be invalid.