1737891 - Pinch-zoom can causes images to disappear.

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[connor24nolan]

Attachment: simplescreenrecorder-2021-10-26_17.05.44.mp4

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:93.0) Gecko/20100101 Firefox/93.0

Steps to reproduce:

First, enable MOZ_USE_XINPUT2. Then open a Google Doc and zoom in.

Actual results:

At a certain zoom level, all the icons disappear. See attached video.

Expected results:

The icons should have stayed visible.

Comment 1

[Clara Guerrero ( Need Info Brindusa Tot Please)]

Attachment: icons disappear.webm

Hi,
Thank you for taking the time to submit this bug report. I was able to reproduce on windows 10 pro in latest Firefox Nightly , Beta and Release , regardless if OZ_USE_XINPUT2 is enabled, and it's also happens in any google file (spreadsheet, presentation, etc)
I've assigned a component in order to get the dev team involved.
Best regards,
Clara

Comment 2

[Darkspirit]

Thanks for the report!

Gnome Xwayland, Debian Testing, Intel, 2560x1600
STR: Google doc at 200% zoom. It's bad when top-left blue doc icon disappears.
Not reproducible with Basic on 2021-08-10 (=before bug 1725388), but reproducible with WebRender.
Not reproducible with Basic on 2018-06-10, but reproducible with WebRender.

MOZ_DISABLE_CONTENT_SANDBOX=1 mozregression --good 2018-01-10 --bad 2018-06-10 --pref gfx.webrender.all:true layers.acceleration.force-enabled:true gfx.webrender.enabled:true gfx.webrendest.enabled:true gfx.webrender.layers-free:true gfx.webrender.blob-images:true image.mem.shared:true layout.display-list.retain:false -a https://docs.google.com/document/d/122SeowelCsXANM0rTyZ0keLuR7dP9h6tbtNh0GYBCR4/edit

5:48.75 INFO: Last good revision: c56ef1c14a555023949ad727c86e3c2df995edd2 (2018-03-13)
5:48.75 INFO: First bad revision: 0d81c80876dd09536f78d1158e1e6ff78f9ad226 (2018-03-14)
5:48.75 INFO: Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c56ef1c14a555023949ad727c86e3c2df995edd2&tochange=0d81c80876dd09536f78d1158e1e6ff78f9ad226

The logo is an SVG sprite, so it could be:

dd37857e52a137fd89bbe721fa610ec97a558a2d Andrew Osmond — Bug 1435291 - Part 2. Make background SVGs use WebRender instead of fallback. r=jrmuizel

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1435291

Comment 4

[Timothy Nikkel (:tnikkel)]

Might have the same root cause bug 1691668.

Comment 5

[Dianna Smith [:diannaS]]

:Andrew can you take a look at this since it seems to be regressed by bug 1435291.?

Comment 6

[Andrew Osmond [:aosmond] (he/him)]

I suspect this is failing because we allocate one large rasterized surface for the entire SVG image map, when we really only need certain resources from it. When you zoom in too much, the allocation fails and we show nothing. Probably this will go away with SVG image blob images. Does flipping image.svg.blob-image to true fix the problem?

Comment 7

[connor24nolan]

Setting image.svg.blob-image to true does fix it!

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Andrew, can you please link this to whatever bug tracks enabling SVG images-as-blobs by default?

Comment 9

[jscher2000]

This bug appears to be the last blocker for bug 1673653 (deferrable-blobs). It seems more like a Depends on than a Blocks to me, but someone better at Bugzilla should please check that.

Comment 10

[Timothy Nikkel (:tnikkel)]

This should be fixed now, can you confirm?

Comment 11

[Mayank Bansal]

(In reply to Timothy Nikkel (:tnikkel) from comment #10)

This should be fixed now, can you confirm?

I am not the OP. But I can confirm that I cannot repro this bug on todays Nightly and I could repro this bug on a Nightly from Jan2023 (when bug 1814878 wouldnt have landed).
IMHO this bug can be closed as FIXED.

Comment 12

[Timothy Nikkel (:tnikkel)]

Thanks. We'll call this fixed. The original reporter doesn't seem likely to get back to us now.