1725388 - Remove/change environment variables and prefs that can disable WR

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task, P3)

Description

[Andrew Osmond [:aosmond] (he/him)]

1. Remove gfx.webrender.force-legacy-layers pref
2. Change MOZ_WEBRENDER=0 to do nothing (may get either HW-WR or SW-WR), MOZ_WEBRENDER=1 continues to force HW-WR unless gfx.webrender.software is true

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1725388 - Remove pref/envvars that can disable WebRender.

MOZ_WEBRENDER=0 now does nothing -- you will either get HW-WR or SW-WR
depending on the platform configuration. The pref
gfx.webrender.force-legacy-layers is removed. This leaves no
configuration option to disable WebRender.

MOZ_WEBRENDER=1 will continue to force WR on, which will ensure in CI we
get HW-WR unless gfx.webrender.software is true.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ee9abeebd43
Remove pref/envvars that can disable WebRender. r=jrmuizel

Comment 3

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1725388 - Part 2. Fix typo in sanity test.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cb961c255c8c
Part 2. Fix typo in sanity test. r=jrmuizel

Comment 5

[Andreea Pavel [:apavel]]

Backed out for causing multiple failures:

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=Hk0zYKx-SJakTzqVKJHeTw.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=4ee9abeebd4307a04f9208c55e4348603181bff3

Failure logs:
bc - browser_startup_mainthreadio.js: https://treeherder.mozilla.org/logviewer?job_id=348239311&repo=autoland&lineNumber=3240
bc: browser_parsable_script.js: https://treeherder.mozilla.org/logviewer?job_id=348239011&repo=autoland&lineNumber=2075
mochitest-chrome: https://treeherder.mozilla.org/logviewer?job_id=348238730&repo=autoland&lineNumber=7066

Backout: https://hg.mozilla.org/integration/autoland/rev/9189a202acd8a2c49834b7661ef1cbb9e266445c

Comment 6

[Narcis Beleuzu [:NarcisB]]

: aosmond , please also take a look over this bc failure on browser_test_clipboardcache.js -> https://treeherder.mozilla.org/logviewer?job_id=348232556&repo=autoland&lineNumber=27862

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/16fa627201d1
Remove pref/envvars that can disable WebRender. r=jrmuizel

Comment 8

[Timothy Nikkel (:tnikkel)]

Can we still have something that devs can use to test non-wr as long as that configuration is still reasonably runnable? I still regularly run into things that are broken with webrender but working with non-wr and knowing that is very useful information.

Comment 9

[Andrew Osmond [:aosmond] (he/him)]

(In reply to Timothy Nikkel (:tnikkel) from comment #8)

Can we still have something that devs can use to test non-wr as long as that configuration is still reasonably runnable? I still regularly run into things that are broken with webrender but working with non-wr and knowing that is very useful information.

The impression I have gotten from others eager to remove code, is that the only reason it hasn't been ripped out yet is because we don't want to break CI. I would be surprised if non-WR makes it another week after this lands :).

Comment 10

[Andrew Osmond [:aosmond] (he/him)]

The code will remain in ESR, although almost no users will be getting it (safe mode, force disable WR). That may be useful as a benchmark for the next year?

Comment 11

[Timothy Nikkel (:tnikkel)]

(In reply to Andrew Osmond [:aosmond] from comment #9)

(In reply to Timothy Nikkel (:tnikkel) from comment #8)

Can we still have something that devs can use to test non-wr as long as that configuration is still reasonably runnable? I still regularly run into things that are broken with webrender but working with non-wr and knowing that is very useful information.

The impression I have gotten from others eager to remove code, is that the only reason it hasn't been ripped out yet is because we don't want to break CI. I would be surprised if non-WR makes it another week after this lands :).

I hope that the apz gtests can still work until Botond has had a chance to refactor them to work in a layer-less world (bug 1593381).

(In reply to Andrew Osmond [:aosmond] from comment #10)

The code will remain in ESR, although almost no users will be getting it (safe mode, force disable WR). That may be useful as a benchmark for the next year?

I plan to just use the last nightly build that non-wr works in for this testing purpose whenever the sunsetting happens.

Comment 12

[Andrew Osmond [:aosmond] (he/him)]

(In reply to Timothy Nikkel (:tnikkel) from comment #11)

(In reply to Andrew Osmond [:aosmond] from comment #9)

(In reply to Timothy Nikkel (:tnikkel) from comment #8)

Can we still have something that devs can use to test non-wr as long as that configuration is still reasonably runnable? I still regularly run into things that are broken with webrender but working with non-wr and knowing that is very useful information.

The impression I have gotten from others eager to remove code, is that the only reason it hasn't been ripped out yet is because we don't want to break CI. I would be surprised if non-WR makes it another week after this lands :).

I hope that the apz gtests can still work until Botond has had a chance to refactor them to work in a layer-less world (bug 1593381).

Yes, mstange brought up that up in the daily. None of my changes will break/disable those tests, since right now the code it needs is still there (and I don't intend to remove it myself). I am going to assume nobody will go out of their way to break tests that are still running.

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/16fa627201d1

Comment 14

[Andrey Lushnikov]

Firefox Headless uses software webrender and can't play certain videos. See this bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1693011

As I result, we were disabling WebRender in Playwright so that our users can play videos. There's no way to disable webrender now – are there any plans to fix the video playback?