1738175 - Implement Pop3Client.jsm to interact with POP3 server

Status: RESOLVED FIXED

(MailNews Core :: Networking: POP, task)

Comment 1

[Ping Chen [:rnons] (away)]

Attachment: Bug 1738175 - Init Pop3Client.jsm to interact with POP3 server. r=mkmelin

Depends on D129897.

Comment 2

[Ping Chen [:rnons] (away)]

Attachment: Bug 1738175 - Support plain auth in Pop3Client.jsm. r=mkmelin

Depends on D130149.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/cc52eea3d0b0
Init Pop3Client.jsm to interact with POP3 server. r=mkmelin
https://hg.mozilla.org/comm-central/rev/bb0e655a611f
Support plain auth in Pop3Client.jsm. r=mkmelin

Comment 4

[Ping Chen [:rnons] (away)]

Attachment: Bug 1738175 - Load popstate.dat to decide which messages to fetch in Pop3Client.jsm. r=mkmelin

Comment 5

[Ping Chen [:rnons] (away)]

Attachment: Bug 1738175 - Make nsIPop3Sink.incorporate* functions usable in JS. r=mkmelin

msg_closure is only used as a flag, can be contained inside nsPop3Protocol.cpp.

Depends on D130608.

Comment 6

[Ping Chen [:rnons] (away)]

Attachment: Bug 1738175 - Fetch messages and use nsIPop3Sink in Pop3Client.jsm. r=mkmelin

Depends on D130609.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f02b11f5ecc1
Load popstate.dat to decide which messages to fetch in Pop3Client.jsm. r=mkmelin
https://hg.mozilla.org/comm-central/rev/3e7f4747fcce
Make nsIPop3Sink.incorporate* functions usable in JS. r=mkmelin

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f1473fd2445c
Fetch messages and use nsIPop3Sink in Pop3Client.jsm. r=mkmelin

Comment 9

[Ping Chen [:rnons] (away)]

Attachment: Bug 1738175 - Support LOGIN and CRAM-MD5 auth in Pop3Client.js. r=mkmelin

Enable test_pop3AuthMethods.js.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/16da852749c9
Support LOGIN and CRAM-MD5 auth in Pop3Client.js. r=mkmelin

Comment 11

[Ping Chen [:rnons] (away)]

Attachment: Bug 1738175 - Implement MsgIncomingServer.shutdown to fix test_pop3AuthMethod.js in debug mode. r=mkmelin

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a8ec74d36f21
Implement MsgIncomingServer.shutdown to fix test_pop3AuthMethod.js in debug mode. r=mkmelin

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4822c550a10b
follow-up - clang-format. rs=clang-format

Comment 14

[Ping Chen [:rnons] (away)]

Attachment: Bug 1738175 - Enable test_pop3Password.js for pop3-js. r=mkmelin

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/85407f980b7b
Enable test_pop3Password.js for pop3-js. r=mkmelin

Comment 16

[Ping Chen [:rnons] (away)]

Attachment: Bug 1738175 - Enable test_pop3PasswordFailure.js for pop3-js.r=mkmelin

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6b2b35540d93
Enable test_pop3PasswordFailure.js for pop3-js. r=mkmelin

Comment 18

[Ping Chen [:rnons] (away)]

Attachment: Bug 1738175 - Call incorporateBegin only once for each message to fix tests. r=mkmelin

There can be multiple responses for a single RETR request, should call incorporateBegin only the first time.

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/11d6e72a0d7c
Call incorporateBegin only once for each message to fix tests. r=mkmelin

Comment 20

[Ping Chen [:rnons] (away)]

Attachment: Bug 1738175 - Support GSSAPI/NTLM/OAUTH auth in Pop3Client.jsm. r=mkmelin

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b949cc5701a6
Support GSSAPI/NTLM/OAUTH auth in Pop3Client.jsm. r=mkmelin

Comment 22

[Ping Chen [:rnons] (away)]

Attachment: Bug 1738175 - Support STARTTLS in Pop3Client.jsm. r=mkmelin

Comment 23

[newsfan]

Are you going to maintain the mail.smtp_login_pop3_user_pass_auth_is_latin1 pref in the JS module?
https://searchfox.org/comm-central/search?q=mail.smtp_login_pop3_user_pass_auth_is_latin1&path=&case=false&regexp=false
There seemed to be installations where login/user/password auth sent characters from the latin1 set without UTF-8 encoding. The pref is true by default.

Comment 24

[Ping Chen [:rnons] (away)]

Thanks, will handle it in the next patch.

Comment 25

[Ping Chen [:rnons] (away)]

(In reply to newsfan from comment #23)

Are you going to maintain the mail.smtp_login_pop3_user_pass_auth_is_latin1 pref in the JS module?
https://searchfox.org/comm-central/search?q=mail.smtp_login_pop3_user_pass_auth_is_latin1&path=&case=false&regexp=false
There seemed to be installations where login/user/password auth sent characters from the latin1 set without UTF-8 encoding. The pref is true by default.

I mistakenly sent it to bug 1738174, handled in D134483.

Comment 26

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4875ebffb1da
Support STARTTLS in Pop3Client.jsm. r=mkmelin

Comment 27

[Ping Chen [:rnons] (away)]

Attachment: Bug 1738175 - Support downloading only headers in Pop3Client.jsm. r=mkmelin

Also delete fully fetched messages if too old or leaveMessagesOnServer is false.

Comment 28

[Ping Chen [:rnons] (away)]

Attachment: Bug 1738175 - Support downloading the rest of a partial message in pop3-js. r=mkmelin

Add Pop3ProtocolHandler.jsm and Pop3Channel.jsm.

Depends on D135312.

Comment 29

[Ping Chen [:rnons] (away)]

Attachment: Bug 1738175 - Enable test_over4GBMailboxes.js for pop3-js. r=mkmelin

Depends on D135313.

Comment 30

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/dcc04339a078
Support downloading only headers in Pop3Client.jsm. r=mkmelin
https://hg.mozilla.org/comm-central/rev/0010317fa5bd
Support downloading the rest of a partial message in pop3-js. r=mkmelin

Comment 31

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/606ce1183f4a
Enable test_over4GBMailboxes.js for pop3-js. r=mkmelin

Comment 32

[Ping Chen [:rnons] (away)]

Attachment: Bug 1738175 - Fix partial message handling in Pop3Client.jsm. r=mkmelin

Two changes:

1. Do not fetch other uidls when downloading full body for a partial message
2. Use OnStartRunningUrl/OnStopRunningUrl to remove the old partial msgHdr

Comment 33

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3d4e2634d0b2
Fix partial message handling in Pop3Client.jsm. r=mkmelin

Comment 34

[Ping Chen [:rnons] (away)]

Attachment: Bug 1738175 - Implement checkMessage in Pop3Client.jsm and fix new mail notification. r=mkmelin

checkMessage is used by nsPop3Sink to decide whether to remove or keep a msg.

Comment 35

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e3569a179c8f
Implement checkMessage in Pop3Client.jsm and fix new mail notification. r=mkmelin

Comment 36

[Ping Chen [:rnons] (away)]

Attachment: Bug 1738175 - Show error prompt in Pop3Client.jsm. r=mkmelin

Comment 37

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1eedb25f0f3e
Show error prompt in Pop3Client.jsm. r=mkmelin

Comment 38

[Ping Chen [:rnons] (away)]

Attachment: Bug 1738175 - Add tests for TOP or RETR command decision in Pop3Client.jsm. r=mkmelin

Depends on D136200.

Comment 39

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6290cff9403c
Add tests for TOP or RETR command decision in Pop3Client.jsm. r=mkmelin