1738331 - Move localization of colorway themes from XPIDatabase.jsm to the manifest

Status: RESOLVED WONTFIX

(Toolkit :: Add-ons Manager, task, P3)

Description

[Harry Twyford]

This requires that we extend the code from bug 1733466 to support properties.

Comment 1

[Rob Wu [:robwu]]

This bug is not entirely obvious to those not in the loop. This bug could be viewed as a follow-up as described at https://bugzilla.mozilla.org/show_bug.cgi?id=1733466#c9

To restate it differently: bug 1733466 describes an issue (built-in extensions cannot be localized with Fluent), and has a long patch stack (also spanning multiple bugs) to get it done. Colorway extensions have a special requirement: their name is not a static string, but depends on a parameter. So to localize colorway extensions, we need a way to define parametric localizations for properties in an extension manifest.

Comment 2

[Rob Wu [:robwu]]

I recall having received a question about the status of the work on supporting Fluent in extension manifest files (of built-in themes).
There are two remaining large tasks:

• Introducing support for parameters in the manifest: https://bugzilla.mozilla.org/show_bug.cgi?id=1733466#c9
• Supporting the scenario of langpack switching: https://bugzilla.mozilla.org/show_bug.cgi?id=1733466#c10

I don't have time to address both issues soon.

The current work-around to deal with the lack of support for the feature is to add custom logic in https://searchfox.org/mozilla-central/rev/eb554e155a28ad36aca62281406757833b9c467a/toolkit/mozapps/extensions/internal/XPIDatabase.jsm#1487-1534. This is far from ideal (and a form of technical debt), but at least it's known and documented in these bugs.