1738354 - today pane relative time "in x min" go stale

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Magnus Melin [:mkmelin]]

Many of my events in the today pane show an outdated relative time.
It says product meeting in 18min, but that was over 12h ago.

I thought it was only for recurring events, but it is not. Seems like it hasn't updated any of the labels since I started up for the morning.

Comment 1

[Geoff Lankow (:darktrojan)]

Check the logging from CalMetronome (you'll need both calendar log preferences set). It doesn't stop the timer without starting a new one, so maybe it isn't starting at all? You could also run CalMetronome.on("minute", console.log); to see if it's going.

Comment 2

[Magnus Melin [:mkmelin]]

Curiously the apparently can go wrong on a per-calendar basis.
For various reasons I had an event from an .ics feed copied to a google calendar. Now both events show next to each other, one says in 4h, and the other in 8 min. Both are wrong, but the 8min one only slightly so.

Comment 3

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1738354 - Stop returning early in CalMetronome.notify. r=mkmelin

When the computer wakes up notify is called immediately and then scheduled to run again within 60s, which won't happen if we return early. By not running a second time, the repeating timer is never set.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/259f5135d5f9
Stop returning early in CalMetronome.notify. r=mkmelin

Comment 5

[Geoff Lankow (:darktrojan)]

Comment on attachment 9255390 [details]
Bug 1738354 - Stop returning early in CalMetronome.notify. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): never worked
User impact if declined: the times for approaching events don't change
Testing completed (on c-c, etc.): landed late last week
Risk to taking this patch (and alternatives if risky): low

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9255390 [details]
Bug 1738354 - Stop returning early in CalMetronome.notify. r=mkmelin

[Triage Comment]
Approved for beta

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 96.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/2dd1fc8e99f3