1738443 - CalDAV calendars are read-only on startup

Status: RESOLVED FIXED

(Calendar :: Provider: CalDAV, defect)

Description

[Edward Paine]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:93.0) Gecko/20100101 Firefox/93.0

Steps to reproduce:

Update to 91.2.1 (from 78)

Actual results:

All CalDAV calendars became read-only. If read-only is unset, it resets itself to read-only when Thunderbird is restarted.

Expected results:

Calendar read-only settings should be preserved.

Comment 1

[Alexander Becker]

I can reproduce this issue at all of my installations, too.
When the read-only option is disabled in the UI and TB is closed,
the prefs.js option calendar.registry.<guid>.readOnly is set to false.
As soon TB is started, the option is changed to true again.

Comment 2

[Alexander Becker]

The problem seems to be caused by this change in calendar/providers/caldav/CalDavCalendar.jsm: D126061 / Bug 1729235

When the server does not support the current-user-privilege-set (as out does), the privs set is empty all the time.
The calender gets read only because none of the expected values are contained in the empty set.

    // line 1095 ff

          let privs = response.firstProps["D:current-user-privilege-set"];
          // Don't clear this.readOnly, only set it. The user may have write
          // privileges but not want to use them.
          if (!this.readOnly && privs && privs instanceof Set) {
            this.readOnly = ![
              "D:write",
              "D:write-content",
              "D:write-properties",
              "D:all",
            ].some(priv => privs.has(priv));

Comment 3

[Lasana Murray]

I can't say I understand the problem here. If we detect we do not have permissions to write to the calendar then it is set to read-only.

Alexander Becker is it that the server you are using sends the current-user-privilege-set property but does not actually use it? What server is this? Are you able to provide a calendar url?

Comment 4

[Edward Paine]

I asked our calDAV provider (VPOP3) for guidance. They don't provide a fully featured webDAV server like Apache, and specifically don't have a current-user-privilege-set property available. Ideally a non-existent property should not not do anything (rather than changing a setting to read-only as in this case).

Comment 5

[Alexander Becker]

The server does not support the current-user-privilege-set property, and tells this in the response.
Thunderbird should simply assume write access if the server does not provide a privilege set.

Here is a fragment of a response to the PROPFIND request:

<D:propstat>
      <D:status>HTTP/1.1 404 Not Found</D:status>
      <D:prop>
        <D:current-user-privilege-set/>
        <CS:getctag/>
      </D:prop>
</D:propstat>

Comment 6

[Lasana Murray]

Attachment: Bug 1738443 - Do not treat 404 current-user-privilege-set responses as an empty list. r=darktrojan

Comment 7

[Alessandro Castellani [:aleca]]

Also this one needs rebasing as it doesn't apply cleanly.

Comment 8

[Magnus Melin [:mkmelin]]

Doesn't apply to tip. Please rebase.

Comment 9

[Lasana Murray]

Updated for D136832 changes.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/11ed8bba1371
Do not treat 404 current-user-privilege-set responses as an empty list. r=darktrojan

Comment 11

[Lasana Murray]

Attachment: WIP: Bug 1738443 - (esr-91) Do not treat 404 current-user-privilege-set responses as an empty list. r=darktrojan

Comment 12

[Lasana Murray]

Attachment: esr91.patch

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: Users of some caldav servers may find them set to read-only unintentionally.
Testing completed (on c-c, etc.): trunk
Risk to taking this patch (and alternatives if risky):
Should be low risk for the user. Separate patch for failed hunks. Did not verify the tests pass on 91.

Comment 13

[Wayne Mery (:wsmwk)]

Comment on attachment 9272174 [details] [diff] [review]
esr91.patch

[Triage Comment]
Approved for esr91

Comment 14

[Rob Lemley [:rjl]]

Thunderbird 91.9.0:
https://hg.mozilla.org/releases/comm-esr91/rev/1bd4a4ff5377