1738613 - color-scheme-aware link colors for dark scheme wrong on windows

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Bill Goldstein [:aja] (UTC-6)]

Attachment: Screenshot 2021-10-31 at 15-56-33 color-scheme-aware Canvas CanvasText and Link colors.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:100.0) Gecko/20100101 Firefox/100.0

Steps to reproduce:

<meta name="color-scheme" content="dark"/>

Actual results:

Canvas/CanvasText for dark scheme are fine, matching:
browser.display.background_color.dark
browser.display.foreground_color.dark

LinkText/VisitedText/ActiveText are NOT matching
browser.anchor_color.dark
browser.visited_color.dark
browser.active_color.dark

Looks like VisitedText/ActiveText actually match the light scheme colors:
browser.visited_color
browser.active_color

LinkText looks like it actually matches Highlight

Expected results:

LinkText/VisitedText/ActiveText should match:
browser.anchor_color.dark
browser.visited_color.dark
browser.active_color.dark

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1738613 - Provide generic dark hyperlink system colors. r=morgan,dholbert

This will make sure they're used on Windows for the dark color scheme.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1738613 - Implement MozNativevisitedhyperlinktext on GTK. r=stransky

This is just drive-by, I noticed we implement one color but not the
other which is unfortunate.

Depends on D129993

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8afba3940af5
Provide generic dark hyperlink system colors. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/9d14c98c0b0e
Implement MozNativevisitedhyperlinktext on GTK. r=stransky

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/8afba3940af5
https://hg.mozilla.org/mozilla-central/rev/9d14c98c0b0e