Windows ASan builds failing due to duplicate rnp.pdb file
Categories
(Thunderbird :: Build Config, defect)
Tracking
(thunderbird_esr91 unaffected, thunderbird95 affected)
Tracking | Status | |
---|---|---|
thunderbird_esr91 | --- | unaffected |
thunderbird95 | --- | affected |
People
(Reporter: rjl, Assigned: rjl)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 obsolete file)
package> mozpack.errors.ErrorMessage: Error: rnp.pdb already added
Assignee | ||
Comment 1•4 years ago
|
||
Ahh.. of course...
The rnp commandline tools were added to the build recently. For Windows, there's rnp.exe which would have a corresponding rnp.pdb file. That conflicts with the existing rnp.dll and its rnp.pdb file.
Options:
- Move rnp.exe and rnpkeys.exe into a subdirectory. The exes' pdb files would then be in the subdirectory and should eliminate the conflict.
- Rename rnp.exe to something else. The corresponding pdb would also be renamed.
- Rename rnp.dll to librnp.dll. Personally, I prefer this option but there's magic and dragons lurking because @DLL_PREFIX@ is an empty string on Windows (thus why we have this conflict in Windows, but not on Unixes where the shared library is named librnp.{so,dylib}).
I'm leaning towards option 3. This will require updating RNPLib.jsm accordingly.
Updated•4 years ago
|
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 3•4 years ago
|
||
The ASan builds package .pdb files for .exe and .dll files. On Windows,
that causes a conflict as rnp.dll and rnp.exe both correspond to rnp.pdb
because DLL_PREFIX is an empty string.
To avoid this conflict, move the "rnp" and "rnpkeys" executables into a
"tools/" subdirectory.
Updated•4 years ago
|
Assignee | ||
Comment 4•4 years ago
|
||
The patch in comment 3 won't work for various reasons. Notably, moving the executables into a subdir means that on Windows, they won't find rnp.dll at runtime. Aside from that, there's pesky packaging issues.
Assignee | ||
Comment 5•4 years ago
|
||
I'm going to rename the RNP CLI executable to "rnp-cli" (or "rnp-cli.exe") so this can get fixed.
Pushed by thunderbird@calypsoblue.org:
https://hg.mozilla.org/comm-central/rev/1a1577aa1d2c
Rename RNP commandline executable to "rnp-cli" to avoid name clash. rs=bustage-fix
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Description
•