1738798 - Windows ASan builds failing due to duplicate rnp.pdb file

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Rob Lemley [:rjl]]

package> mozpack.errors.ErrorMessage: Error: rnp.pdb already added

Comment 1

[Rob Lemley [:rjl]]

Ahh.. of course...

The rnp commandline tools were added to the build recently. For Windows, there's rnp.exe which would have a corresponding rnp.pdb file. That conflicts with the existing rnp.dll and its rnp.pdb file.

Options:

• Move rnp.exe and rnpkeys.exe into a subdirectory. The exes' pdb files would then be in the subdirectory and should eliminate the conflict.
• Rename rnp.exe to something else. The corresponding pdb would also be renamed.
• Rename rnp.dll to librnp.dll. Personally, I prefer this option but there's magic and dragons lurking because @DLL_PREFIX@ is an empty string on Windows (thus why we have this conflict in Windows, but not on Unixes where the shared library is named librnp.{so,dylib}).

I'm leaning towards option 3. This will require updating RNPLib.jsm accordingly.

Comment 2

[Intermittent Failures Robot]

2 failures in 3030 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 2

Platform and build breakdown:

• windows2012-64: 2
  • asan: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1738798&startday=2021-11-01&endday=2021-11-07&tree=all

Comment 3

[Rob Lemley [:rjl]]

Attachment: Bug 1738798 - Move RNP cli tools into a subdirectory to avoid name conflicts. r=kaie

The ASan builds package .pdb files for .exe and .dll files. On Windows,
that causes a conflict as rnp.dll and rnp.exe both correspond to rnp.pdb
because DLL_PREFIX is an empty string.

To avoid this conflict, move the "rnp" and "rnpkeys" executables into a
"tools/" subdirectory.

Comment 4

[Rob Lemley [:rjl]]

The patch in comment 3 won't work for various reasons. Notably, moving the executables into a subdir means that on Windows, they won't find rnp.dll at runtime. Aside from that, there's pesky packaging issues.

Comment 5

[Rob Lemley [:rjl]]

I'm going to rename the RNP CLI executable to "rnp-cli" (or "rnp-cli.exe") so this can get fixed.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1a1577aa1d2c
Rename RNP commandline executable to "rnp-cli" to avoid name clash. rs=bustage-fix

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b20dc21684bb
Follow-up: Copy rnp-cli executable to right place for macOS build. rs=bustage-fix