173897 - Fix |XXX - mod_perl| comments

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Bradley Baetz (:bbaetz)]

As I've been cleaning up code recently, I've been adding comment arround things
which are not safe to use with mod_perl, as well as the reasons why, and often
how it needs to be fixed

Before we can enable mod_perl mode, this needs to be fixed.

grep for 'XXX.*mod_perl' to catch all these.

Comment 1

[Dave Miller [:justdave]]

Reassigning bugs that I'm not actively working on to the default component owner
in order to try to make some sanity out of my personal buglist.  This doesn't
mean the bug isn't being dealt with, just that I'm not the one doing it.  If you
are dealing with this bug, please assign it to yourself.

Comment 2

[Dave Miller [:justdave]]

As of this writing, there's only 3 of these left.

Bugzilla/CGI.pm:86:        # XXX - under mod_perl we can use the request object to
Bugzilla/Template.pm:73:# XXX - mod_perl
Bugzilla/Template.pm:108:    # XXXX - mod_perl!

The latter two are already taken care of in the patch on bug 343338, which leaves only the one in Bugzilla/CGI.pm to deal with on this bug.  It sounds like all we need to do is tell Apache to generate ErrorDocuments on mod_perl v1.

Comment 3

[Frédéric Buclin]

Doing a grep with '#.*mod_perl' as regexp, I can find only two occurences which need some consideration:

Bugzilla/CGI.pm:
86:        # XXX - under mod_perl we can use the request object to
90:        # Under mod_perl v2, though, this happens automatically, and the

That's the one reported by justdave in comment 2.

Bugzilla/DB.pm:
673:    # Apache::DBI will cache this when using mod_perl

mkanat, I think we are very close to fixing this bug. :)

Comment 4

[Max Kanat-Alexander]

Hrm. We don't support mod_perl v1, so that fix won't be necessary. We can just remove that comment.

The Apache::DBI thing doesn't even matter, since that happens automatically in the startup script (which we haven't checked-in yet, and which I haven't even posted as a patch yet, since I'm experimenting with it).

Comment 5

[Max Kanat-Alexander]

Attachment: v1

Okay, all I had to do was remove a single comment. :-) We're actually fine, since we use mod_perl v2.

Comment 6

[Max Kanat-Alexander]

Checking in Bugzilla/CGI.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/CGI.pm,v  <--  CGI.pm
new revision: 1.28; previous revision: 1.27
done