1739055 - Custom homepage / start page lost after upgrade to 94; overwritten by "Firefox Home"

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[-]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:94.0) Gecko/20100101 Firefox/94.0

Steps to reproduce:

Firefox updated itself to 94.0.

Actual results:

I have set my start page to a news portal. When I open a new tab and click the home icon, the default start page just reloads.

Looking in the options, I see that the URL of the news portal is gone, the address field is just blank.

Expected results:

The new Firefox version should have kept the URL that I set.

Comment 1

[Andre Klapper]

I have set my start page to a news portal.

Same here.

When I open a new tab and click the home icon, the default start page just reloads.

Not the same here. My custom start page loads and the upgrade from Firefox 93 to Firefox 94 did not change anything.

Comment 4

[Mark Heijl]

I can confirm this is happening, I experienced the same behaviour in two of my installations. Selected a new Colorway in both cases.

Comment 5

[Gingerbread Man]

Marking this NEW based on the additional reports.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::DOM: Navigation' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 8

[Hsin-Yi Tsai (she/her) [:hsinyi]]

It directly impacts our user experience right after upgrading, which is concerning, so S2 for now.

Looking at the duplicates, I'm not sure it's DOM Navigation bug. Maybe Session Restore?
Andreas will investigate a bit first. Thanks!

Comment 9

[Hsin-Yi Tsai (she/her) [:hsinyi]]

I was pointed that the onboarding flow for 94 have an option to reset homepage to Firefox Home. Perhaps these reports are coming from mistaken use of that option?

https://support.mozilla.org/en-US/kb/personalize-firefox-colorways
https://support.mozilla.org/en-US/questions/1356557

Comment 10

[Tracy Walker [:tracy]]

Please see the support article for Colorways onboarding in Fx94- https://support.mozilla.org/en-US/kb/personalize-firefox-colorways
Take notice of:
"Note: If you have a custom Home page at the time of selecting an optional Colorway, you will see the Switch to Firefox Home with themed background option. Checking this box will reset your custom home page to the default Firefox Home page. "

Comment 11

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Firefox:Theme should be a better fit for this issue or have experts to confirm what's up with the option setting.

Comment 12

[Tracy Walker [:tracy]]

Also, see https://support.mozilla.org/en-US/kb/how-to-set-the-home-page for guide how to customize your homepage.

Comment 13

[Rummskartoffel]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #9)

I was pointed that the onboarding flow for 94 have an option to reset homepage to Firefox Home. Perhaps these reports are coming from mistaken use of that option?

I couldn't remember having selected any such option, so I went through the update again just now. Here's what I found:

If you get to the "Pick your palette" screen and then click "Keep previous theme" while not unselecting "Switch to Firefox Home with themed background", the custom homepage is reset anyway.
I find that unintuitive. I expected it to work like a "Cancel" button, because that's what it looks like, and it didn't.

Comment 14

[Ray Fambro]

I can investigate any potential paths to improve this UI with the UX team (would be targeting the Fx96 train though). Just for clarity, this behavior is correct as spec'd. But there may be a way to make it more clear for users that want to opt out of changing their home page.

Comment 15

[Ray Fambro]

Thanks for updating this one Punam. I've aligned with UX and we will address this bug in Fx96.
Desired behavior is listed below:

If “Switch to Firefox home” checkbox is selected:

• “Save colorway” = update colorway and update custom home page to Firefox Home.
• “Keep previous theme” = do not update colorway, do not update custom home page (can checkbox be set to automatically deselect here?)

If “Switch to Firefox home” checkbox is deselected:

• “Save colorway” = update colorway, do not update custom home page to Firefox Home.
• “Keep previous theme” = do not update colorway, do not update custom home page.

Comment 16

[Ed Lee :Mardak]

Attachment: Bug 1739055 - Reset custom homepage / start page only on saving colorway r?pdahiya

Handle checkbox only from primary button and not any completion of colorway screen.

Depends on D130930

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9af1e399cd87
Reset custom homepage / start page only on saving colorway r=pdahiya

Comment 18

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/9af1e399cd87

Comment 19

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Beta (96.0b5 Build ID - 20211214203716) installed on Windows 10 x64, macOS 11.6, and Linux Mint 20.2 x64. Now I can confirm the following:

• If the “Switch to Firefox home” checkbox is selected:

  • “Save colorway” = update colorway and update the custom home page to Firefox Home.
  • “Keep previous theme” = do not update colorway, do not update custom home page (can checkbox be set to automatically deselect here?)

• If the “Switch to Firefox home” checkbox is deselected:

  • “Save colorway” = update colorway, do not update the custom home page to Firefox Home.
  • “Keep previous theme” = do not update colorway, do not update the custom home page.