1739406 - [perfdocs] Prevent perfdocs from running multiple times in one call

Status: RESOLVED FIXED

(Testing :: Performance, defect, P3)

Description

[Greg Mierzwinski [:sparky]]

Perfdocs currently gets triggered multiple times because of this chunk size that splits the paths into multiple jobs: https://searchfox.org/mozilla-central/source/python/mozlint/mozlint/roller.py#265-275

We should find a way to fix this so we only run it once.

Comment 1

[Greg Mierzwinski [:sparky]]

:ahal, would you have any ideas for how we could solve this issue?

Comment 2

[Andrew Halberstadt [:ahal]]

Not off the top of my head..

Though it kind of sounds like perfdocs shouldn't be a linter in this case. Am I correct that it always runs against the full set of files regardless of which paths get passed in? The fundamental assumption of mozlint is that linters receive a list of paths as arguments and then only runs analysis against those paths.

If this is the case, I think it would be better to re-factor this check into a mach python-test test.

Comment 3

[Greg Mierzwinski [:sparky]]

Hmm, ok thanks!

I don't think we'll bother with this then (at least for now) since that sounds like a good amount of work for little benefit. I'll leave the bug open for the future though.

Comment 4

[Andrew Halberstadt [:ahal]]

Oh wait, I guess I'm wrong :p

Looks like you can just set type: global:
https://searchfox.org/mozilla-central/source/python/mozlint/mozlint/roller.py#268

I think this was implemented for the android-lint hooks. I remember also pushing back on that at the time, but let it slide. So my mistake..

Comment 5

[Greg Mierzwinski [:sparky]]

Oh that's cool, thanks for finding that :ahal!

We'll think about which method to take. I'm not a fan of having to move the tool again, but maybe python-test could provide us with some other value.

Comment 6

[Calixte Denizet (:calixte)]

I ran ./mach lint -l perfdocs in the windows moz-shell and it was a bad idea:

• there are some encoding issue when reading the files;
• then the directory: https://searchfox.org/mozilla-central/rev/d34f9713ae128a3138c2b70d8041a535f1049d19/tools/lint/perfdocs/utils.py#92 is not existing in my setup;
• I get then other encoding issues easily fixed,
• at the end it works but the resulting diff is unusable:
  • / are replaced with some \
  • eol are wrong
  • some encoding issues.

Comment 8

[Greg Mierzwinski [:sparky]]

This should be resolved now with the move to ./mach perfdocs