1872613 - single_alert.png not found when generating perfdocs

Status: RESOLVED FIXED

(Testing :: Performance, defect, P5)

Description

[Joshua Marshall]

The first time I try to generate perfdocs, I get the following error. Weird doubling in the stack trace too. The second time, it works.

$ ./mach lint -l perfdocs . --fix --warnings --outgoing
0:05.39 INFO Found 9 perfdocs directories in ['/home/jcm/moz/perf-integration/mozilla-central/devtools/perfdocs', '/home/jcm/moz/perf-integration/mozilla-central/testing/performance/fxrecord/perfdocs', '/home/jcm/moz/perf-integration/mozilla-central/testing/performance/perf-sheriffing/perfdocs', '/home/jcm/moz/perf-integration/mozilla-central/testing/performance/mach-try-perf/perfdocs', '/home/jcm/moz/perf-integration/mozilla-central/testing/awsy/perfdocs', '/home/jcm/moz/perf-integration/mozilla-central/testing/raptor/raptor/perfdocs', '/home/jcm/moz/perf-integration/mozilla-central/testing/talos/perfdocs', '/home/jcm/moz/perf-integration/mozilla-central/python/mozperftest/perfdocs', '/home/jcm/moz/perf-integration/mozilla-central/dom/indexedDB/test/perfdocs']
0:06.72 INFO Found 9 perfdocs directories in ['/home/jcm/moz/perf-integration/mozilla-central/devtools/perfdocs', '/home/jcm/moz/perf-integration/mozilla-central/testing/performance/fxrecord/perfdocs', '/home/jcm/moz/perf-integration/mozilla-central/testing/performance/perf-sheriffing/perfdocs', '/home/jcm/moz/perf-integration/mozilla-central/testing/performance/mach-try-perf/perfdocs', '/home/jcm/moz/perf-integration/mozilla-central/testing/awsy/perfdocs', '/home/jcm/moz/perf-integration/mozilla-central/testing/raptor/raptor/perfdocs', '/home/jcm/moz/perf-integration/mozilla-central/testing/talos/perfdocs', '/home/jcm/moz/perf-integration/mozilla-central/python/mozperftest/perfdocs', '/home/jcm/moz/perf-integration/mozilla-central/dom/indexedDB/test/perfdocs']
0:06.52 INFO Found 9 perfdocs directories in ['/home/jcm/moz/perf-integration/mozilla-central/devtools/perfdocs', '/home/jcm/moz/perf-integration/mozilla-central/testing/performance/fxrecord/perfdocs', '/home/jcm/moz/perf-integration/mozilla-central/testing/performance/perf-sheriffing/perfdocs', '/home/jcm/moz/perf-integration/mozilla-central/testing/performance/mach-try-perf/perfdocs', '/home/jcm/moz/perf-integration/mozilla-central/testing/awsy/perfdocs', '/home/jcm/moz/perf-integration/mozilla-central/testing/raptor/raptor/perfdocs', '/home/jcm/moz/perf-integration/mozilla-central/testing/talos/perfdocs', '/home/jcm/moz/perf-integration/mozilla-central/python/mozperftest/perfdocs', '/home/jcm/moz/perf-integration/mozilla-central/dom/indexedDB/test/perfdocs']
0:10.01 INFO Regenerating perfdocs...
0:08.88 INFO Regenerating perfdocs...
0:10.21 INFO Regenerating perfdocs...
Traceback (most recent call last):
Traceback (most recent call last):
File "/home/jcm/moz/perf-integration/mozilla-central/python/mozlint/mozlint/roller.py", line 72, in _run_worker
res = func(paths, config, **lintargs)
File "/home/jcm/moz/perf-integration/mozilla-central/python/mozlint/mozlint/roller.py", line 72, in _run_worker
res = func(paths, config, **lintargs)
File "/home/jcm/moz/perf-integration/mozilla-central/python/mozlint/mozlint/types.py", line 57, in call
return self._lint(paths, config, **lintargs)
File "/home/jcm/moz/perf-integration/mozilla-central/python/mozlint/mozlint/types.py", line 57, in call
return self._lint(paths, config, **lintargs)
File "/home/jcm/moz/perf-integration/mozilla-central/python/mozlint/mozlint/types.py", line 200, in _lint
func(files, config, logger, **lintargs)
File "/home/jcm/moz/perf-integration/mozilla-central/python/mozlint/mozlint/types.py", line 200, in _lint
func(files, config, logger, **lintargs)
File "/home/jcm/moz/perf-integration/mozilla-central/tools/lint/perfdocs/init.py", line 13, in lint
return perfdocs.run_perfdocs(config, logger=logger, paths=paths, generate=fix)
File "/home/jcm/moz/perf-integration/mozilla-central/tools/lint/perfdocs/init.py", line 13, in lint
return perfdocs.run_perfdocs(config, logger=logger, paths=paths, generate=fix)
File "/home/jcm/moz/perf-integration/mozilla-central/tools/lint/perfdocs/perfdocs.py", line 95, in run_perfdocs
generator.generate_perfdocs()
File "/home/jcm/moz/perf-integration/mozilla-central/tools/lint/perfdocs/perfdocs.py", line 95, in run_perfdocs
generator.generate_perfdocs()
File "/home/jcm/moz/perf-integration/mozilla-central/tools/lint/perfdocs/generator.py", line 268, in generate_perfdocs
self._save_perfdocs(perfdocs_tmpdir)
File "/home/jcm/moz/perf-integration/mozilla-central/tools/lint/perfdocs/generator.py", line 268, in generate_perfdocs
self._save_perfdocs(perfdocs_tmpdir)
File "/home/jcm/moz/perf-integration/mozilla-central/tools/lint/perfdocs/generator.py", line 209, in _save_perfdocs
shutil.rmtree(str(self.perfdocs_path))
File "/home/jcm/moz/perf-integration/mozilla-central/tools/lint/perfdocs/generator.py", line 209, in _save_perfdocs
shutil.rmtree(str(self.perfdocs_path))
File "/usr/lib/python3.10/shutil.py", line 725, in rmtree
_rmtree_safe_fd(fd, path, onerror)
File "/usr/lib/python3.10/shutil.py", line 725, in rmtree
_rmtree_safe_fd(fd, path, onerror)
File "/usr/lib/python3.10/shutil.py", line 681, in _rmtree_safe_fd
onerror(os.unlink, fullname, sys.exc_info())
File "/usr/lib/python3.10/shutil.py", line 681, in _rmtree_safe_fd
onerror(os.unlink, fullname, sys.exc_info())
File "/usr/lib/python3.10/shutil.py", line 679, in _rmtree_safe_fd
os.unlink(entry.name, dir_fd=topfd)
File "/usr/lib/python3.10/shutil.py", line 679, in _rmtree_safe_fd
os.unlink(entry.name, dir_fd=topfd)
FileNotFoundError: [Errno 2] No such file or directory: 'single_alert.png'
FileNotFoundError: [Errno 2] No such file or directory: 'single_alert.png'
0:08.88 INFO Documentation saved to testing/perfdocs/generated/
A failure occurred in the perfdocs linter.
✖ 1 problem (0 errors, 0 warnings, 1 failure, 0 fixed)

Comment 1

[Greg Mierzwinski [:sparky]]

This is likely related to a race-condition, see bug 1739406.

Comment 2

[Greg Mierzwinski [:sparky]]

This should be resolved now with the move to ./mach perfdocs