Old profiles break in TB91, if the default PAB entry is not an sqlite address book (no AB, unable to send mails)
Categories
(Thunderbird :: Address Book, defect)
Tracking
(thunderbird_esr91+ fixed, thunderbird98 fixed)
People
(Reporter: TbSync, Assigned: TbSync)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
48 bytes,
text/x-phabricator-request
|
wsmwk
:
approval-comm-beta+
wsmwk
:
approval-comm-esr91+
|
Details | Review |
This is from the prefs.js of such an older profile:
user_pref("ldap_2.servers.pab.csid", "iso-8859-1");
user_pref("ldap_2.servers.pab.filename", "pab.na2");
user_pref("ldap_2.servers.pab.locale", "German_Germany");
user_pref("ldap_2.servers.pab.position", 2);
user_pref("ldap_2.servers.pab.replication.lastChangeNumber", 0);
user_pref("ldap_2.servers.pab_1.csid", "iso-8859-1");
user_pref("ldap_2.servers.pab_1.description", "pab");
user_pref("ldap_2.servers.pab_1.dirType", 101);
user_pref("ldap_2.servers.pab_1.filename", "abook.sqlite");
user_pref("ldap_2.servers.pab_1.isOffline", false);
user_pref("ldap_2.servers.pab_1.locale", "German_Germany");
user_pref("ldap_2.servers.pab_1.replication.lastChangeNumber", 0);
user_pref("ldap_2.servers.pab_1.uid", "11e8db95-8793-4032-8cbe-34024822681f");
This profile worked in TB78 and failed after upgrading to TB91. As you can see, the default pap
entry is an older pab.na2
file. The actual used PAB is the pab_1
entry.
The user can rescue his profile by swapping pab and pab_1 entries.
Thunderbird should not assume the standard pab entry to be an sqlite file.
I can provide the 100MB profile to reproduce but since it is not mine, I cannot attach it to the bug.
Assignee | ||
Updated•10 months ago
|
Assignee | ||
Comment 1•9 months ago
•
|
||
The *.na2
addressbook files are seen as jsaddrbook URL:
jsaddrbook://pab.na2
and are treated as sqlite databases and will die here:
https://searchfox.org/comm-central/rev/6e63f411c4df40dfef72dbfa9fb8a091eccfe386/mailnews/addrbook/modules/SQLiteDirectory.jsm#43
What is the strategy? Harden the different functions to not die and skip those files, or removing those old entries from the prefs / directory?
Comment 2•9 months ago
|
||
I think the best thing to do is just fix the affected profile(s). .na2 address books are ancient technology (well before my time) and there's unlikely to be many of them around so I don't think it's worth trying to change the code for.
Comment 3•9 months ago
|
||
Maybe we should still check if file.path.endsWith(".sqlite") and ignore if not. It was always named .sqlite, right?
Comment 4•9 months ago
|
||
I suppose so.
Assignee | ||
Comment 5•9 months ago
|
||
I misread comment 2. I assumed that meant to be a wontfix and users should fix their profiles. I will have a go at it.
Updated•7 months ago
|
Assignee | ||
Comment 6•7 months ago
|
||
I keep forgetting about this one. Will try to fix it now.
Assignee | ||
Updated•7 months ago
|
Assignee | ||
Comment 7•7 months ago
|
||
Assignee | ||
Updated•7 months ago
|
Assignee | ||
Updated•7 months ago
|
Updated•7 months ago
|
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/59927c5a3a79
Prevent usage of incompatible address book files. r=darktrojan
Comment 9•7 months ago
|
||
Backed out for test failures:
https://hg.mozilla.org/comm-central/rev/e46a1e0933537b7b8e40265039584753c189f679
Assignee | ||
Updated•6 months ago
|
Assignee | ||
Updated•6 months ago
|
Comment 10•6 months ago
|
||
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/395b57d41a6d
Prevent usage of incompatible address book files. r=darktrojan
Comment 11•6 months ago
|
||
Might as well uplift this asap.
Assignee | ||
Comment 12•6 months ago
•
|
||
Comment on attachment 9259591 [details]
Bug 1739498 - Prevent usage of incompatible address book files. r=darktrojan
[Approval Request Comment]
Regression caused by (bug #):
User impact if declined:
Old profiles which still use some older file types and somehow have missed migration, crash.
Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky):
Hard to say. We need to check closely for test fails.
Comment 13•6 months ago
|
||
Comment on attachment 9259591 [details]
Bug 1739498 - Prevent usage of incompatible address book files. r=darktrojan
[Triage Comment]
Approved for beta
Comment 14•6 months ago
|
||
bugherderuplift |
Thunderbird 98.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/4b4b5c95d5a3
Assignee | ||
Comment 15•5 months ago
•
|
||
Comment on attachment 9259591 [details]
Bug 1739498 - Prevent usage of incompatible address book files. r=darktrojan
[Approval Request Comment]
Regression caused by (bug #):
User impact if declined:
Old profiles which still use some older file types and somehow have missed migration, crash.
Testing completed (on c-c, etc.):
On beta since 8 days
Risk to taking this patch (and alternatives if risky):
If we did not see an increase in beta crashes, it should be fine.
Comment 16•5 months ago
|
||
Comment on attachment 9259591 [details]
Bug 1739498 - Prevent usage of incompatible address book files. r=darktrojan
[Triage Comment]
Approved for esr91
Comment 17•5 months ago
|
||
bugherderuplift |
Thunderbird 91.8.0:
https://hg.mozilla.org/releases/comm-esr91/rev/6731e13d9a9e
Description
•