1739594 - mach commands spawn `hg outgoing` which may ask for ssh key etc

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, defect)

Description

[Julien Cristau [:jcristau]]

Somehow every time I run mach (even just --help) it runs hg outgoing -r . --quiet --template "{file_adds % '{file}\n'}{file_dels % '{file}\n'}{file_mods % '{file}\n'}" default in the background, which in turns runs ssh hg.mozilla.org 'hg -R integration/mozilla-inbound serve --stdio' (because for whatever reason my ~/.hgrc has inbound as default-push), which then means my ssh agent asks for a passphrase. Can we avoid hitting the network here if possible?

Comment 1

[Mitchell Hentges [:mhentges] 🦀]

Hmm, this is likely our "should exceptions be reported to Sentry" logic.

Can you share your .hg/hgrc (or ~/.hgrc, if you repo config is somehow in there) so I can better-understand whyhg` is deciding to hit the network?

Comment 2

[Julien Cristau [:jcristau]]

~/.hgrc contains this:

[paths]
try = ssh://hg.mozilla.org/try
default-push = ssh://hg.mozilla.org/integration/mozilla-inbound

Comment 3

[Julien Cristau [:jcristau]]

I've disabled mach telemetry for now which gets rid of the spurious hg outgoing calls. And yes this is from the "should exceptions be reported to Sentry" logic.

Comment 4

[Mitchell Hentges [:mhentges] 🦀]

~/.hgrc contains this:

Aside: why is your repo-local config in your home directory? ~/.hgrc is referring to /home/jcristau/.hgrc, is it not?
I'd expect ~/.hgrc to contain your enabled extensions, username, config, etc.

Comment 5

[Mike Hommey [:glandium]]

hg outgoing always hits the network.

Comment 6

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1739594: Don't hit network to resolve VCS-changed files

Unless an upstream is specified, we should be able to detect which files
are changed on our local branch without hitting the network.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c3ad16eab9cc
Don't hit network to resolve VCS-changed files r=ahal

Comment 8

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/c3ad16eab9cc